alex/swayfx
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

transaction: don't reconfigure X views unless integral coords changed

Browse source 
Sway logical coordinates are doubles, but they get truncated to integers
when sent to Xwayland through `xcb_configure_window`. X11 apps will not
respond to duplicate configure requests (from their truncated point of
view) and cause transactions to time out.

Fixes #5035.
This commit is contained in:
Tudor Brindus 2020-10-18 15:55:52 -04:00 committed by Simon Ser
parent 33affb33d2
commit 5bd6a5ce3f
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
sway/desktop/transaction.c
View file

@ -397,8 +397,12 @@ static bool should_configure(struct sway_node *node,
// Xwayland views are position-aware and need to be reconfigured // Xwayland views are position-aware and need to be reconfigured
// when their position changes. // when their position changes.
if (node->sway_container->view->type == SWAY_VIEW_XWAYLAND) { if (node->sway_container->view->type == SWAY_VIEW_XWAYLAND) {
if (cstate->content_x != istate->content_x || // Sway logical coordinates are doubles, but they get truncated to
cstate->content_y != istate->content_y) { // integers when sent to Xwayland through `xcb_configure_window`.
// X11 apps will not respond to duplicate configure requests (from their
// truncated point of view) and cause transactions to time out.
if ((int)cstate->content_x != (int)istate->content_x ||
(int)cstate->content_y != (int)istate->content_y) {
return true; return true;
} }
} }