alex/swayfx
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

seat_cmd_cursor: do not create non-existing seat

Browse source 
If a seat does not exist in seat_cmd_cursor, do not create it. A seat
without any attachments is useless since it will have no capabilities.

This changes `input_manager_get_seat` to have an additional argument
that dictates whether or not to create the seat if it does not exist.
This commit is contained in:
Brian Ashworth 2019-02-03 13:56:05 -05:00
parent 8e60efe0bf
commit 7299b9a6ca
4 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/sway/input/input-manager.h
View file

@ -45,7 +45,7 @@ void input_manager_apply_seat_config(struct seat_config *seat_config);
struct sway_seat *input_manager_get_default_seat(void); struct sway_seat *input_manager_get_default_seat(void);
struct sway_seat *input_manager_get_seat(const char *seat_name); struct sway_seat *input_manager_get_seat(const char *seat_name, bool create);
/** /**
* If none of the seat configs have a fallback setting (either true or false), * If none of the seat configs have a fallback setting (either true or false),

5
sway/commands/seat/cursor.c
View file

@ -61,9 +61,10 @@ struct cmd_results *seat_cmd_cursor(int argc, char **argv) {
} }
if (strcmp(sc->name, "*") != 0) { if (strcmp(sc->name, "*") != 0) {
struct sway_seat *seat = input_manager_get_seat(sc->name); struct sway_seat *seat = input_manager_get_seat(sc->name, false);
if (!seat) { if (!seat) {
return cmd_results_new(CMD_FAILURE, "Failed to get seat"); return cmd_results_new(CMD_FAILURE,
"Seat %s does not exist", sc->name);
} }
error = handle_command(seat->cursor, argc, argv); error = handle_command(seat->cursor, argc, argv);
} else { } else {

6
sway/config.c
View file

@ -149,8 +149,10 @@ static void destroy_removed_seats(struct sway_config *old_config,
/* Also destroy seats that aren't present in new config */ /* Also destroy seats that aren't present in new config */
if (new_config && list_seq_find(new_config->seat_configs, if (new_config && list_seq_find(new_config->seat_configs,
seat_name_cmp, seat_config->name) < 0) { seat_name_cmp, seat_config->name) < 0) {
seat = input_manager_get_seat(seat_config->name); seat = input_manager_get_seat(seat_config->name, false);
seat_destroy(seat); if (seat) {
seat_destroy(seat);
}
} }
} }
} }

9
sway/input/input-manager.c
View file

@ -31,10 +31,10 @@ struct sway_seat *input_manager_current_seat(void) {
} }
struct sway_seat *input_manager_get_default_seat(void) { struct sway_seat *input_manager_get_default_seat(void) {
return input_manager_get_seat(DEFAULT_SEAT); return input_manager_get_seat(DEFAULT_SEAT, true);
} }
struct sway_seat *input_manager_get_seat(const char *seat_name) { struct sway_seat *input_manager_get_seat(const char *seat_name, bool create) {
struct sway_seat *seat = NULL; struct sway_seat *seat = NULL;
wl_list_for_each(seat, &server.input->seats, link) { wl_list_for_each(seat, &server.input->seats, link) {
if (strcmp(seat->wlr_seat->name, seat_name) == 0) { if (strcmp(seat->wlr_seat->name, seat_name) == 0) {
@ -42,7 +42,7 @@ struct sway_seat *input_manager_get_seat(const char *seat_name) {
} }
} }
return seat_create(seat_name); return create ? seat_create(seat_name) : NULL;
} }
char *input_device_get_identifier(struct wlr_input_device *device) { char *input_device_get_identifier(struct wlr_input_device *device) {
@ -674,7 +674,8 @@ void input_manager_apply_seat_config(struct seat_config *seat_config) {
seat_apply_config(seat, sc); seat_apply_config(seat, sc);
} }
} else { } else {
struct sway_seat *seat = input_manager_get_seat(seat_config->name); struct sway_seat *seat =
input_manager_get_seat(seat_config->name, true);
if (!seat) { if (!seat) {
return; return;
} }