alex/swayfx
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

transaction: Improve transaction commentary

Browse source 
Some comments where slightly misleading.
This commit is contained in:
Kenny Levinsen 2020-06-03 02:40:48 +02:00 committed by Simon Ser
parent 645cf76f8a
commit 7670f1a521
1 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
sway/desktop/transaction.c
View file

@ -341,8 +341,8 @@ static void transaction_progress_queue(void) {
if (!server.transactions->length) { if (!server.transactions->length) {
return; return;
} }
// There's only ever one committed transaction, // Only the first transaction in the queue is committed, so that's the one
// and it's the first one in the queue. // we try to process.
struct sway_transaction *transaction = server.transactions->items[0]; struct sway_transaction *transaction = server.transactions->items[0];
if (transaction->num_waiting) { if (transaction->num_waiting) {
return; return;
@ -351,7 +351,8 @@ static void transaction_progress_queue(void) {
transaction_destroy(transaction); transaction_destroy(transaction);
list_del(server.transactions, 0); list_del(server.transactions, 0);
if (!server.transactions->length) { if (server.transactions->length == 0) {
// The transaction queue is empty, so we're done.
sway_idle_inhibit_v1_check_active(server.idle_inhibit_manager_v1); sway_idle_inhibit_v1_check_active(server.idle_inhibit_manager_v1);
return; return;
} }
@ -369,6 +370,7 @@ static void transaction_progress_queue(void) {
} }
} }
// We again commit the first transaction in the queue to process it.
transaction = server.transactions->items[0]; transaction = server.transactions->items[0];
transaction_commit(transaction); transaction_commit(transaction);
transaction_progress_queue(); transaction_progress_queue();
@ -533,8 +535,7 @@ void transaction_commit_dirty(void) {
list_add(server.transactions, transaction); list_add(server.transactions, transaction);
// There's only ever one committed transaction, // We only commit the first transaction added to the queue.
// and it's the first one in the queue.
if (server.transactions->length == 1) { if (server.transactions->length == 1) {
transaction_commit(transaction); transaction_commit(transaction);
// Attempting to progress the queue here is useful // Attempting to progress the queue here is useful