Merge pull request #2208 from RyanDwyer/instruction-use-after-free

Fix use after free in transaction code
This commit is contained in:
Ryan Dwyer 2018-07-04 23:21:41 +10:00 committed by GitHub
commit 7efeacf16c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -377,7 +377,9 @@ static void set_instructions_ready(struct sway_view *view, int index) {
for (int i = 0; i <= index; ++i) { for (int i = 0; i <= index; ++i) {
struct sway_transaction_instruction *instruction = struct sway_transaction_instruction *instruction =
view->swayc->instructions->items[i]; view->swayc->instructions->items[i];
set_instruction_ready(instruction); if (!instruction->ready) {
set_instruction_ready(instruction);
}
} }
} }