alex/swayfx
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

output: fix updating output manager config

Browse source 
The output manager config is created when the output is created. It is
updated when the mode, transform, scale, or layout for the output
changes, as well as, when the output is destroyed.

Since the output->enabled property was not being set before calling
apply_output_config, the output event handlers were early returning and
never updating the output manager config when the output state was
committed.

This fixes the issue by setting output->enabled in apply_output_config
below the output disabling section. There are also a few other minor
changes that are required to function.

Additionally, this renames output_enable to output_configure to better
describe the recent changes.
This commit is contained in:
Brian Ashworth 2020-02-16 01:47:59 -05:00 committed by Simon Ser
parent 447967ad3a
commit 8b593677d2
3 changed files with 15 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/sway/output.h
View file

@ -101,7 +101,7 @@ struct sway_output *all_output_by_name_or_id(const char *name_or_id);
void output_sort_workspaces(struct sway_output *output); void output_sort_workspaces(struct sway_output *output);
void output_enable(struct sway_output *output); void output_configure(struct sway_output *output);
void output_disable(struct sway_output *output); void output_disable(struct sway_output *output);

8
sway/config/output.c
View file

@ -345,6 +345,9 @@ bool apply_output_config(struct output_config *oc, struct sway_output *output) {
return wlr_output_commit(wlr_output); return wlr_output_commit(wlr_output);
} }
bool was_enabled = output->enabled;
output->enabled = true;
if (!oc || oc->dpms_state != DPMS_OFF) { if (!oc || oc->dpms_state != DPMS_OFF) {
sway_log(SWAY_DEBUG, "Turning on output %s", wlr_output->name); sway_log(SWAY_DEBUG, "Turning on output %s", wlr_output->name);
wlr_output_enable(wlr_output, true); wlr_output_enable(wlr_output, true);
@ -393,6 +396,7 @@ bool apply_output_config(struct output_config *oc, struct sway_output *output) {
// output disabled for now and try again when the output gets the mode // output disabled for now and try again when the output gets the mode
// we asked for. // we asked for.
sway_log(SWAY_ERROR, "Failed to modeset output %s", wlr_output->name); sway_log(SWAY_ERROR, "Failed to modeset output %s", wlr_output->name);
output->enabled = was_enabled;
return false; return false;
} }
@ -432,8 +436,8 @@ bool apply_output_config(struct output_config *oc, struct sway_output *output) {
output->width = output_box->width; output->width = output_box->width;
output->height = output_box->height; output->height = output_box->height;
if ((!oc || oc->enabled) && !output->enabled) { if ((!oc || oc->enabled) && !output->configured) {
output_enable(output); output_configure(output);
} }
if (oc && oc->dpms_state == DPMS_OFF) { if (oc && oc->dpms_state == DPMS_OFF) {

17
sway/tree/output.c
View file

@ -102,20 +102,19 @@ struct sway_output *output_create(struct wlr_output *wlr_output) {
output->workspaces = create_list(); output->workspaces = create_list();
output->current.workspaces = create_list(); output->current.workspaces = create_list();
return output;
}
void output_enable(struct sway_output *output) {
if (!sway_assert(!output->enabled, "output is already enabled")) {
return;
}
struct wlr_output *wlr_output = output->wlr_output;
size_t len = sizeof(output->layers) / sizeof(output->layers[0]); size_t len = sizeof(output->layers) / sizeof(output->layers[0]);
for (size_t i = 0; i < len; ++i) { for (size_t i = 0; i < len; ++i) {
wl_list_init(&output->layers[i]); wl_list_init(&output->layers[i]);
} }
output->enabled = true; return output;
}
void output_configure(struct sway_output *output) {
if (!sway_assert(!output->configured, "output is already configured")) {
return;
}
struct wlr_output *wlr_output = output->wlr_output;
output->configured = true; output->configured = true;
list_add(root->outputs, output); list_add(root->outputs, output);