alex/swayfx
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

swaybar: Group child processes for signalling

Browse source 
Fixes child proccess killing, when status_command is a complex command
like "i3status | wrapper.sh".

Set the process group id of the child process by calling `setpgid` after
forking and before calling `exec`.

The process group ID will be set to the process ID of the forked
process. Processes spawned by this child process will also have this
group ID.

Send signals to the process group with `killpg`. This will send the
signal to all of the process group.
This commit is contained in:
Yury Krivopalov 2017-06-12 23:01:19 +03:00
parent 154cc8a9c3
commit 8f4bc0a374
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
swaybar/bar.c
View file

@ -34,6 +34,7 @@ static void spawn_status_cmd_proc(struct bar *bar) {
close(pipefd[0]); close(pipefd[0]);
dup2(pipefd[1], STDOUT_FILENO); dup2(pipefd[1], STDOUT_FILENO);
close(pipefd[1]); close(pipefd[1]);
setpgid(bar->status_command_pid, 0);
char *const cmd[] = { char *const cmd[] = {
"sh", "sh",
"-c", "-c",
@ -274,7 +275,7 @@ static void free_outputs(list_t *outputs) {
static void terminate_status_command(pid_t pid) { static void terminate_status_command(pid_t pid) {
if (pid) { if (pid) {
// terminate status_command process // terminate status_command process
int ret = kill(pid, SIGTERM); int ret = killpg(pid, SIGTERM);
if (ret != 0) { if (ret != 0) {
sway_log(L_ERROR, "Unable to terminate status_command [pid: %d]", pid); sway_log(L_ERROR, "Unable to terminate status_command [pid: %d]", pid);
} else { } else {