alex/swayfx
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

swaybar: ipc_update_ws: Fix memory corruption.

Browse source 
json_object_object_get_ex does not require json_object_put according to
docs, this should fix the random crashes.
This commit is contained in:
S. Christoffer Eliesen 2015-12-18 15:30:46 +01:00
parent a116eafaa4
commit de219f6bec
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
swaybar/main.c
View file

@ -135,10 +135,6 @@ void ipc_update_workspaces() {
int i; int i;
for (i = 0; i < json_object_array_length(results); ++i) { for (i = 0; i < json_object_array_length(results); ++i) {
json_object *ws_json = json_object_array_get_idx(results, i); json_object *ws_json = json_object_array_get_idx(results, i);
if (!ws_json) {
// wat
continue;
}
json_object *num, *name, *visible, *focused, *out, *urgent; json_object *num, *name, *visible, *focused, *out, *urgent;
json_object_object_get_ex(ws_json, "num", &num); json_object_object_get_ex(ws_json, "num", &num);
json_object_object_get_ex(ws_json, "name", &name); json_object_object_get_ex(ws_json, "name", &name);
@ -156,14 +152,6 @@ void ipc_update_workspaces() {
ws->urgent = json_object_get_boolean(urgent); ws->urgent = json_object_get_boolean(urgent);
list_add(workspaces, ws); list_add(workspaces, ws);
} }
json_object_put(num);
json_object_put(name);
json_object_put(visible);
json_object_put(focused);
json_object_put(out);
json_object_put(urgent);
json_object_put(ws_json);
} }
json_object_put(results); json_object_put(results);