Drew DeVault
5222e14555
Merge pull request #2155 from ael-code/fix_output_command_failure
...
bugfix: avoid access after free
2018-06-22 06:53:17 -07:00
ael-code
ad085c1332
bugfix: avoid access after free
...
if src is NULL due to a previous error we cannot use it in the command
result string.
Moreover if `src` points to `p.we_wordv[0]` we cannot use it after
`wordfree(&p)` in the command result string.
Bonus feature: If there was an error accessing the file, the string
rapresentation of the error is now included in the command result
string.
2018-06-22 15:41:44 +02:00
Drew DeVault
e8fbda4d21
Merge pull request #2146 from tobiasblass/prepare_server_before_dropping_privileges
...
Perform (partial) server initialization before dropping privileges.
2018-06-22 06:41:34 -07:00
Rostislav Pehlivanov
aa9f058e3e
Init the dmabuf exporting protocol in wlroots
...
Allows desktop capture via the dmabuf-capture wlroots example client.
2018-06-22 13:45:32 +01:00
Tobias Blass
a5c091e302
Perform (partial) server initialization before dropping privileges.
...
Some operations during backend creation (e.g. becoming DRM master)
require CAP_SYS_ADMIN privileges. At this point, sway has dropped them
already, though. This patch splits the privileged part of server_init
into its own function and calls it before dropping its privileges.
This fixes the bug with minimal security implications.
2018-06-19 00:19:57 +02:00
emersion
cda66e9a26
Automatically float xwayland windows
2018-06-18 22:52:10 +01:00
Ryan Dwyer
1c89f32533
Preserve buffers during transactions
...
* Also fix parts of the rendering where it was rendering the pending
state instead of current.
2018-06-18 20:42:12 +10:00
Ryan Dwyer
645bf446fa
Merge remote-tracking branch 'upstream/master' into atomic
2018-06-18 15:58:48 +10:00
emersion
088cae45c8
Update for swaywm/wlroots#1060
2018-06-16 13:32:23 -04:00
frsfnrrg
ca061ba8bf
Fix keyboard shortcut handling inconsistencies
...
* Ensure that modifier keys are identified even when the next key does
not produce a keysym. This requires that modifier change tracking
be done for each sway_shortcut_state.
* Permit regular and --release shortcuts on the same key combination.
Distinct bindings are identified for press and release cases; note
that the release binding needs to be identified for both key press
and key release events.
* Maintain ascending sort order for the shortcut state list, and keep
track of the number of pressed key ids, for simpler (and hence
faster) searching of the list of key bindings.
* Move binding duplicate detection into get_active_binding to avoid
duplicating error messages.
2018-06-12 20:26:57 -04:00
frsfnrrg
b23cd827cf
Sort binding key lists
...
Sort the list comprising the set of keys for the binding in ascending
order. (Keyboard shortcuts depend only on the set of simultaneously
pressed keys, not their order, so this change should have no external
effect.) This simplifies comparisons between bindings.
2018-06-12 11:26:24 -04:00
Ryan Dwyer
9e96cfd310
Merge remote-tracking branch 'upstream/master' into atomic
2018-06-11 11:03:43 +10:00
Drew DeVault
867fb6aedb
Merge pull request #2124 from emersion/drag-icons
...
Render drag icons
2018-06-09 10:50:34 -07:00
Nate Symer
6a910b9ba5
Implement gaps (PR #2047 )
2018-06-09 09:34:56 -04:00
emersion
cfd02918c0
Render drag icons
2018-06-09 13:26:03 +01:00
emersion
88cd7616db
Fix compilation errors related to disabled outputs
2018-06-09 11:38:16 +01:00
Ryan Dwyer
bb66e6d578
Refactor everything that needs to arrange windows
...
* The arrange_foo functions are now replaced with arrange_and_commit, or
with manually created transactions and arrange_windows x2.
* The arrange functions are now only called from the highest level
functions rather than from both high level and low level functions.
* Due to the previous point, view_set_fullscreen_raw and
view_set_fullscreen are both merged into one function again.
* Floating and fullscreen are now working with transactions.
2018-06-09 10:11:25 +10:00
Ryan Dwyer
f9e6d703d2
Make main properties be the pending state
2018-06-09 10:08:43 +10:00
Ryan Dwyer
59c9488701
WIP: Atomic layout updates ground work
2018-06-09 10:08:43 +10:00
Brian Ashworth
e2b2fb0a0e
Switch restore workspaces to a nested for-loop
2018-06-08 13:08:00 -04:00
Brian Ashworth
5c9a917df9
Restore workspaces to outputs based on priority
2018-06-08 13:08:00 -04:00
emersion
acf71fe805
Merge pull request #2119 from martinetd/gcc-strtruncation
...
sway/criteria: gcc string truncation warning fix
2018-06-08 14:41:33 +01:00
Dominique Martinet
720313e185
sway/criteria: gcc string truncation warning fix
2018-06-08 22:30:13 +09:00
Dominique Martinet
d26a0a1a6e
sway exec command: use waitpid instead of wait
2018-06-08 22:28:28 +09:00
Brian Ashworth
212e4ef395
Remove strip quoting and fix strncpy-overlap
2018-06-07 20:37:08 -04:00
emersion
07bee8cffe
Merge pull request #2084 from RedSoxFan/runtime-var-expansion
...
Runtime variable expansion
2018-06-07 19:29:26 +01:00
Brian Ashworth
e072fbc6d9
Switch output storing from list_t to wl_list
2018-06-06 20:11:24 -04:00
Brian Ashworth
a0bbe67076
Address emersions comments on output re-enabling
2018-06-06 20:11:24 -04:00
Brian Ashworth
a1b5b93d29
Store sway_outputs so that they can be reenabled
2018-06-06 20:11:24 -04:00
Brian Ashworth
82b3b587dd
Remove tab/stack check for focusing after a split
2018-06-06 19:38:38 -04:00
Brian Ashworth
e7261e2917
Fix focusing after splitting tabs/stacks
2018-06-06 16:41:19 -04:00
Scott Leggett
609c420501
Initialise previous cursor position.
...
Fix the problem with focus jumping to the container under the cursor
when first starting sway.
2018-06-06 20:45:02 +10:00
Tobias Blass
d6d292897f
Remove suspicious unconditional return
...
This return effectively disables the log_kernel function
2018-06-05 23:27:35 +02:00
Brian Ashworth
f4870d5432
Fix logic issue in do_var_replacement
2018-06-05 10:08:00 -04:00
Brian Ashworth
067fe9d047
Support runtime var expansion and set at runtime
2018-06-05 10:08:00 -04:00
emersion
0f71547032
Merge pull request #2095 from emersion/fullscreen-damage-only-visible
...
Only send frame to visible surfaces when fullscreened
2018-06-05 11:18:52 +01:00
emersion
6b9ffbad20
Merge pull request #2103 from RyanDwyer/focus-fixes
...
Focus fixes
2018-06-05 08:44:53 +01:00
Brian Ashworth
9aaac8b8c8
Fix movement crashes/issues
2018-06-05 01:13:27 -04:00
Ryan Dwyer
1206a60977
Don't restore focus if unmapping surface wasn't focused
2018-06-04 13:31:09 +10:00
Ryan Dwyer
bcdb676abb
Don't set focus to NULL when clicking a surface which has no container
2018-06-04 11:31:25 +10:00
Ryan Dwyer
9253278328
Restore focus when unmapping layer shell surfaces
2018-06-04 11:31:07 +10:00
Ryan Dwyer
74799937cf
Restore focus when unmapping unmanaged xwayland surfaces
2018-06-04 11:30:26 +10:00
emersion
0549fd027b
Merge pull request #2087 from RedSoxFan/output-subcommand
...
Refactor cmd_output to use config_subcommand
2018-06-03 18:48:00 +01:00
emersion
6d0ad6a1ed
Merge pull request #2099 from RyanDwyer/fix-seat-get-active-child
...
Fix seat_get_active_child
2018-06-03 18:46:48 +01:00
Brian Ashworth
51fa988be9
Address review comments for output subcommands
2018-06-03 10:29:00 -04:00
Brian Ashworth
5ea4a4d3ee
Refactor cmd_output to use config_subcommand
2018-06-03 10:26:06 -04:00
Ryan Dwyer
d02e9aa4bc
Fix initial workspace orientation on a rotated output
2018-06-03 23:39:09 +10:00
Ryan Dwyer
57e78414fa
Fix seat_get_active_child
...
seat_get_active_child is used for tabbed and stacked containers to get
the active child. The previous implementation used seat_get_focus_inactive
then ascended the tree to the child of the tabbed/stacked container, but
this fails when the workspace itself is stacked or tabbed and the most
recently active child is floating.
The new implementation takes a more simple approach, where it directly
scans the focus stack for the first immediate child which isn't the
floating container.
Fixes #2098 .
2018-06-03 22:31:54 +10:00
emersion
ebe0b668c9
Merge pull request #2093 from emersion/damage-debug
...
Add SWAY_DAMAGE_DEBUG
2018-06-03 10:31:19 +01:00
emersion
8e3d19aad2
Merge pull request #2096 from kupospelov/fix-title-update
...
Fix view title update order
2018-06-03 09:20:57 +01:00
Ryan Dwyer
8289e30308
Fix potential crash when destroying workspace
...
`_container_destroy` emits a destroy event, and any listener for this
event should have access to the full container, not a half destroyed
one.
`_container_destroy` also destroys the swayc, so we have to grab a
reference to the sway_workspace so we can free it afterwards.
This also fixes a memory leak where the floating container wasn't freed.
Fixes #2092 .
2018-06-03 10:28:24 +10:00
Konstantin Pospelov
e6baac4297
Fix view title update order
...
This commit fixes the function call order to make sure that the title
texture is updated using the relevant global font size.
2018-06-03 00:32:18 +03:00
emersion
55b855d867
Add SWAY_DAMAGE_DEBUG
...
Setting it to "rerender" will always re-render everything
regardless of the damaged region. Setting it to "highlight" will
clear the screen and render only damaged regions.
2018-06-02 21:57:34 +01:00
emersion
34bdf25bb5
Only send frame to visible surfaces when fullscreened
2018-06-02 20:56:33 +01:00
emersion
51eee3aecc
Schedule a frame even if damage is empty
2018-06-02 20:42:26 +01:00
Dominique Martinet
71ab13f1eb
sway/config: fix use-after-free for end of block
...
Introduced in 7c810dc344
2018-06-03 00:31:51 +09:00
Drew DeVault
df204b65d8
Merge pull request #2089 from emersion/send-frame-done-visible
...
Only send frame done to visible views
2018-06-02 08:13:01 -07:00
emersion
65845be802
Only send frame done to visible views
...
Also don't accumulate empty damage
2018-06-02 15:19:03 +01:00
Brian Ashworth
8bfa2def88
Address first round of review for generic blocks
2018-06-02 08:07:44 -04:00
Brian Ashworth
51bb9d8573
Support braces on next line for config blocks
2018-06-02 08:07:44 -04:00
Brian Ashworth
7c810dc344
Make command block implementation generic
2018-06-02 08:07:44 -04:00
emersion
2d480e754e
Merge pull request #2080 from frsfnrrg/keyboard-remodeling
...
Reduce work duplication in keyboard and binding code
2018-06-02 09:18:07 +01:00
Ryan Dwyer
3f1cfd547e
Fix top border when a view is initially floating
...
Fixes #2085 .
2018-06-02 11:45:16 +10:00
frsfnrrg
78b7b46895
Style fix, redundant entry removal, fix extra keysym delete
2018-06-01 18:52:36 -04:00
frsfnrrg
480f0c593c
Rename update_shortcut_model to update_shortcut_state
2018-06-01 18:52:36 -04:00
frsfnrrg
83d559dd03
Rename check_shortcut_model to get_active_binding
2018-06-01 18:52:36 -04:00
frsfnrrg
c53e4e6cde
Style fixed for keyboard.c
2018-06-01 18:52:36 -04:00
frsfnrrg
eb00edc6e2
Style fixes for bind.c
2018-06-01 18:52:36 -04:00
frsfnrrg
f2fe93d171
Remove almost-always redundant loop in key handling
2018-06-01 18:52:36 -04:00
frsfnrrg
705230a26c
Fix binding bindcode flag initialization
2018-06-01 18:52:36 -04:00
frsfnrrg
a056419ad7
Rewrite shortcut handling code to avoid hardcoded values
...
The same shortcut algorithm is now used for keycodes,
raw keysyms, and translated keysyms. Pressed keysyms
are now stored in association with the keycodes that
generated them. Modifier keycodes (and associated
keysyms) are identified retroactively by the subsequent
change to the modifier flags.
2018-06-01 18:52:36 -04:00
frsfnrrg
f5ed65e633
Use XKB keycode numbering for bindcode
2018-06-01 18:52:36 -04:00
frsfnrrg
d77681ea3d
Share common code between bindsym and bindcode commands
2018-06-01 18:52:36 -04:00
Drew DeVault
96446fdbf7
Merge pull request #2027 from RyanDwyer/implement-floating
...
Implement floating
2018-06-01 15:41:49 -07:00
Brian Ashworth
edf37f27e1
Fix cmd_workspace crash when a surface has focus
2018-06-01 14:07:55 -04:00
Ryan Dwyer
70c2c50445
Fix changing borders on floating views
2018-06-01 23:14:58 +10:00
Ryan Dwyer
d466b8fa7b
Don't auto float xdg views if their dimensions are not set
2018-06-01 23:14:58 +10:00
Ryan Dwyer
a2c1cb9072
Fix mpv damage issue when unfullscreening into floating
2018-06-01 23:14:58 +10:00
Ryan Dwyer
c9e3a313b4
Fix fullscreen position of xwayland views
2018-06-01 23:14:58 +10:00
Ryan Dwyer
00cac22038
Fix crash when using multiple outputs
2018-06-01 23:14:58 +10:00
Drew DeVault
e605dc43bb
Fix mouse warping interaction with layout coords
2018-06-01 23:14:58 +10:00
Ryan Dwyer
c9f8d35ca9
Consider floating views when calculating title height
2018-06-01 23:14:58 +10:00
Ryan Dwyer
9119f87655
Fix floating position when view is floated when mapped
2018-06-01 23:14:58 +10:00
Ryan Dwyer
f7cadf2333
Adjust move command to account for changed coordinate system
2018-06-01 23:14:58 +10:00
Ryan Dwyer
f24087d104
Fix fullscreen position
2018-06-01 23:14:58 +10:00
Ryan Dwyer
97672295ed
Don't unmaximize floating views
2018-06-01 23:14:58 +10:00
Ryan Dwyer
40af5d81a1
Fix getting adjacent output
2018-06-01 23:14:58 +10:00
Ryan Dwyer
becceafa7f
Remove unfinished wants_floating implementation for xwayland
2018-06-01 23:14:58 +10:00
Ryan Dwyer
5b1601c2e3
Don't let xwayland views set position unless unmanaged
2018-06-01 23:14:58 +10:00
Ryan Dwyer
02d385e06f
Use swayc rather than wlr_output when rendering
2018-06-01 23:14:58 +10:00
Ryan Dwyer
3b1db30a5e
Use surface size if xdg shell's geometry isn't set
2018-06-01 23:14:58 +10:00
Ryan Dwyer
4371c746e4
Implement wants_floating for xdg_shell and xdg_shell_v6
2018-06-01 23:14:58 +10:00
Ryan Dwyer
d4ed204d4d
Remove container_self_or_parent_floating
2018-06-01 23:14:58 +10:00
Ryan Dwyer
70f5d6fcf3
Rename container_set_geometry_from_view
2018-06-01 23:14:58 +10:00
Ryan Dwyer
3281574fa3
Remove check for if floating view intersects output
2018-06-01 23:14:58 +10:00
Ryan Dwyer
7d2b33a458
Render floating views before top layer and unmanaged
2018-06-01 23:14:58 +10:00
Ryan Dwyer
e4e912ea91
Store swayc coordinates as layout-local
2018-06-01 23:14:58 +10:00
Ryan Dwyer
00f6e179cd
Add L_FLOATING back to debug tree
2018-06-01 23:14:58 +10:00
Ryan Dwyer
02de2a6f65
Rename set_maximized functions to set_tiled
2018-06-01 23:14:58 +10:00
Ryan Dwyer
5d69a56209
Prevent splitting a floating view
2018-06-01 23:14:58 +10:00
