swayfx/sway/tree
Simon Ser 5432f00adf config/output: don't change output state before commit
Previously, we called output_disable prior to wlr_output_commit. This
mutates Sway's output state before the output commit actually succeeds.
This results in Sway's state getting out-of-sync with wlroots'.

An alternative fix [1] was to revert the changes made by output_disable
in case of failure. This is a little complicated. Instead, this patch
makes it so Sway's internal state is never changed before a successful
wlr_output commit.

We had two output flags: enabled and configured. However enabled was set
prior to the output becoming enabled, and was used to prevent the output
event handlers (specifically, the mode handler) from calling
apply_output_config again (infinite loop).

Rename enabled to enabling and use it exclusively for this purpose.
Rename configure to enabled, because that's what it really means.

[1]: https://github.com/swaywm/sway/pull/5521

Closes: https://github.com/swaywm/sway/issues/5483
2020-07-10 18:18:27 -04:00
..
arrange.c Make sure we don't calculate fractional pixel gaps 2020-01-01 10:14:29 -07:00
container.c commands/move: maintain workspace_layout when moving 2020-07-03 18:40:59 -04:00
node.c Fix scratchpad fullscreen behavior and crash 2019-04-13 08:48:37 -06:00
output.c config/output: don't change output state before commit 2020-07-10 18:18:27 -04:00
root.c Fix crash when showing scratchpad hidden split containers 2020-01-16 21:48:25 -05:00
view.c tree/view: fix segfault in view_update_title 2020-07-03 09:23:35 +02:00
workspace.c commands/move: unwrap workspace container on move to new workspace 2020-07-01 18:43:20 -04:00