swayfx/sway/commands
Alyssa Ross 5fb5984e94 bar: fix segfault with missing or invalid bar id
Prior to this patch, if I ran something like this, sway would crash:

    swaymsg bar height 50

or

    swaymsg bar not-a-bar-id color bg #ff0000

This was in contrast to other bar subcommands, like status_command,
which would exit with a "No bar defined" message.

The difference between the subcommands that crashed and the ones that
exited was that some subcommands had a check to see if a bar was
specified, while others just assumed that it had been and carried on
until they segfaulted.

Because this check was identical in every subcommand it was present in,
and I couldn't think of a case where it would be valid to run a bar
subcommand without specifying which bar to apply it to, I moved this
check from individual subcommands into the bar command, which is already
responsible for actually setting the specified bar. This reduced code
duplication, and fixed the crash for the subcommands that were missing
this check.
2019-05-17 15:33:57 -04:00
..
bar bar: fix segfault with missing or invalid bar id 2019-05-17 15:33:57 -04:00
input Merge pull request #3480 from RedSoxFan/input-modes-improved-toggle 2019-01-21 09:28:47 -05:00
output Implement output toggle 2019-05-14 00:11:04 -04:00
seat seat_cmd_cursor: fix typo in expected syntax 2019-02-17 20:16:23 -05:00
assign.c Replace wlr_log with sway_log 2019-01-21 12:59:42 +01:00
bar.c bar: fix segfault with missing or invalid bar id 2019-05-17 15:33:57 -04:00
bind.c config: simplify keysym translation fields 2019-04-26 20:56:48 +03:00
border.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
client.c Replace wlr_log with sway_log 2019-01-21 12:59:42 +01:00
create_output.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
default_border.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
default_floating_border.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
default_orientation.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
exec.c Replace wlr_log with sway_log 2019-01-21 12:59:42 +01:00
exec_always.c Replace wlr_log with sway_log 2019-01-21 12:59:42 +01:00
exit.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
floating.c Fix scratchpad fullscreen behavior and crash 2019-04-13 08:48:37 -06:00
floating_minmax_size.c Replace wlr_log with sway_log 2019-01-21 12:59:42 +01:00
floating_modifier.c Move sway-specific functions in common/util.c into sway/ 2019-01-21 12:39:16 -05:00
focus.c Fix scratchpad fullscreen behavior and crash 2019-04-13 08:48:37 -06:00
focus_follows_mouse.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
focus_on_window_activation.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
focus_wrapping.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
font.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
for_window.c Replace wlr_log with sway_log 2019-01-21 12:59:42 +01:00
force_display_urgency_hint.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
force_focus_wrapping.c Add deprecation warnings for new_float, new_window, and force_focus_wrapping. 2019-04-14 20:44:12 -04:00
fullscreen.c Fix scratchpad fullscreen behavior and crash 2019-04-13 08:48:37 -06:00
gaps.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
hide_edge_borders.c hide_edge_borders.c: add missing case for --i3 2019-04-19 00:05:49 +03:00
include.c Make load_include_configs void. Fix some cases where WD would not be restored. 2019-02-24 00:01:35 -05:00
inhibit_idle.c Implement inhibit_idle command 2019-03-24 19:26:12 -06:00
input.c bindsym: consider xkb_rule_names for --to-code 2019-04-26 20:56:48 +03:00
kill.c Replace wlr_log with sway_log 2019-01-21 12:59:42 +01:00
layout.c Fix scratchpad fullscreen behavior and crash 2019-04-13 08:48:37 -06:00
mark.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
mode.c cmd_mode: allow cmd_set to be a subcommand 2019-03-23 08:07:25 +02:00
mouse_warping.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
move.c cmd_move: add support for output current 2019-04-30 15:22:02 -06:00
new_float.c Add deprecation warnings for new_float, new_window, and force_focus_wrapping. 2019-04-14 20:44:12 -04:00
new_window.c Add deprecation warnings for new_float, new_window, and force_focus_wrapping. 2019-04-14 20:44:12 -04:00
no_focus.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
nop.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
opacity.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
output.c Implement output toggle 2019-05-14 00:11:04 -04:00
popup_during_fullscreen.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
reload.c Replace wlr_log with sway_log 2019-01-21 12:59:42 +01:00
rename.c Allow for workspace renaming during exec handling 2019-03-23 17:49:27 -04:00
resize.c floating_maximum_size: change default behavior 2019-03-02 09:10:26 +01:00
scratchpad.c Handle seat_get_focused_workspace returning NULL 2019-03-12 19:14:04 +01:00
seat.c fix misc memory leaks 2019-02-11 10:10:48 +01:00
set.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
show_marks.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
smart_borders.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
smart_gaps.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
split.c Fix scratchpad fullscreen behavior and crash 2019-04-13 08:48:37 -06:00
sticky.c Handle NULL from output_get_active_workspace 2019-02-21 21:18:03 +01:00
swap.c Handle NULL from output_get_active_workspace 2019-02-21 21:18:03 +01:00
swaybg_command.c Replace wlr_log with sway_log 2019-01-21 12:59:42 +01:00
swaynag_command.c Replace wlr_log with sway_log 2019-01-21 12:59:42 +01:00
tiling_drag.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
tiling_drag_threshold.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
title_align.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
title_format.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
titlebar_border_thickness.c Handle NULL from output_get_active_workspace 2019-02-21 21:18:03 +01:00
titlebar_padding.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
unmark.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
urgent.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
workspace.c Handle seat_get_focused_workspace returning NULL 2019-03-12 19:14:04 +01:00
workspace_layout.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
ws_auto_back_and_forth.c Remove now-unused "input" argument of cmd_results_new 2019-01-14 08:05:29 -05:00
xwayland.c Replace wlr_log with sway_log 2019-01-21 12:59:42 +01:00