Go to file
Ryan Dwyer b14bd1b0b1 Fix crash when closing last child of a tabbed container
The crash only occurs if the mouse cursor is above the tabbed container
when the last child is closed.

Introduced in 03d49490cc, over a week ago
and unnoticed until now :O

The above commit changes the behaviour of a focus change. When you
change focus, it sends pointer motion which makes the client set a new
cursor image. We already had this behaviour for workspace switching, but
this commit adds it for view switching too, such as in a tabbed
container or when closing a view.

The sequence of events that leads to the crash is:

* The last child of a tabbed container unmaps, which triggers a
`destroy` event before we've cleaned up the child or reaped the tabbed
container.
* The seat code listens to the `destroy` event and removes the seat
container from the focus stack. As part of this, it decides to set focus
to the parent (my fix alters this decision).
* When setting focus to the new parent, the container motion is sent as
per the previously mentioned commit.
* The motion code uses `container_at`, which encounters the tabbed
container and its child in a half destroyed state, and everything blows
up from there.

`con->parent` is needed because scratchpad containers don't have parents
if they're hidden, so this probably fixes a crash when a hidden
scratchpad container closes too.

The `con->parent->children->length > 1` check should catch any cases
where the parent is about to be reaped.
2018-07-25 19:26:12 +10:00
assets Recompressed PNG files 2017-01-05 21:49:28 -05:00
client Set pool_buffers busy when handing them out 2018-06-17 17:34:12 -04:00
common Address review comments on parse_boolean 2018-07-23 21:37:53 -04:00
completions/zsh Remove clipboard command and get_clipboard message 2018-07-10 22:09:21 +01:00
contrib Move awesome config to contrib/ 2017-01-14 16:03:41 -05:00
include Implement floating_modifier <mod> [inverse|normal] 2018-07-24 18:41:08 -04:00
protocols Swaylock: Allow per-output images 2018-05-20 22:54:09 +10:00
security.d Revert "security.d: Update install paths for swaybar and swaybg" 2018-05-06 00:19:12 +01:00
sway Fix crash when closing last child of a tabbed container 2018-07-25 19:26:12 +10:00
swaybar swaybar: Fix scroll handling on workspace buttons 2018-07-19 21:15:01 +02:00
swaybg swaybar/bg: Fix crash on DPMS off 2018-07-14 00:04:02 +02:00
swayidle swayidle: cleanup 2018-07-16 22:20:53 +01:00
swaylock Fix swaylock arguments 2018-07-17 21:50:15 -04:00
swaymsg Remove clipboard command and get_clipboard message 2018-07-10 22:09:21 +01:00
.build.yml Add scdoc to .build.yml 2018-05-11 21:40:52 -04:00
.clang-format Update .clang-format - not entirely usable yet 2017-01-10 23:30:34 -05:00
.editorconfig Create .editorconfig 2016-07-04 14:12:32 +02:00
.gitignore Add subprojects to gitignore 2018-03-28 12:22:28 -04:00
config.in Implement pid->workspace tracking 2018-07-01 09:58:18 -04:00
CONTRIBUTING.md Update for swaywm/wlroots#1126 2018-07-09 22:54:30 +01:00
HACKING.md Update for swaywm/wlroots#1126 2018-07-09 22:54:30 +01:00
LICENSE MIT license 2017-01-06 13:45:48 -05:00
meson.build Automatically float xwayland windows 2018-06-18 22:52:10 +01:00
meson_options.txt Revert "Make the LIBDIR path configurable" 2018-05-06 00:19:52 +01:00
README.de.md Update README.md + README.*.md 2018-05-11 22:57:47 -04:00
README.el.md Update README.md + README.*.md 2018-05-11 22:57:47 -04:00
README.fr.md Fix typos 2018-05-12 08:58:48 -04:00
README.it.md Update README.md + README.*.md 2018-05-11 22:57:47 -04:00
README.ja.md Update README.md + README.*.md 2018-05-11 22:57:47 -04:00
README.md Update README.md + README.*.md 2018-05-11 22:57:47 -04:00
README.pt.md Update README.md + README.*.md 2018-05-11 22:57:47 -04:00
README.ru.md Update README.md + README.*.md 2018-05-11 22:57:47 -04:00
README.uk.md Update README.md + README.*.md 2018-05-11 22:57:47 -04:00
sway.desktop Add Wayland and Xorg session files 2015-08-20 23:12:34 +02:00

sway

English - 日本語 - Deutsch - Ελληνικά - Français - Українська - Italiano - Português - Русский

"SirCmpwn's Wayland compositor" is a work in progress i3-compatible Wayland compositor. Read the FAQ. Join the IRC channel (#sway on irc.freenode.net).

Notice: You are viewing the unstable and unsupported master branch of sway, where work is ongoing to port it to wlroots. The supported branch is the 0.15 branch, and end users are encouraged to use the stable releases cut from it.

If you'd like to support sway development, please contribute to SirCmpwn's Patreon page.

Release Signatures

Releases are signed with B22DA89A and published on GitHub.

Status

Installation

From Packages

Sway is available in many distributions. Try installing the "sway" package for yours. If it's not available, check out this wiki page for information on installation for your distributions.

If you're interested in packaging sway for your distribution, stop by the IRC channel or shoot an email to sir@cmpwn.com for advice.

Compiling from Source

Install dependencies:

  • meson
  • wlroots
  • wayland
  • xwayland
  • libinput >= 1.6.0
  • libcap
  • pcre
  • json-c >= 0.13
  • pango
  • cairo
  • gdk-pixbuf2 *
  • pam **
  • dbus >= 1.10 ***
  • imagemagick (required for image capture with swaygrab)
  • ffmpeg (required for video capture with swaygrab)
  • scdoc (required for man pages)

*Only required for swaybar, swaybg, and swaylock

**Only required for swaylock

***Only required for tray support

Run these commands:

meson build
ninja -C build
sudo ninja -C build install

On systems with logind, you need to set a few caps on the binary:

sudo setcap "cap_sys_ptrace,cap_sys_tty_config=eip" /usr/local/bin/sway

On systems without logind, you need to suid the sway binary:

sudo chmod a+s /usr/local/bin/sway

Configuration

If you already use i3, then copy your i3 config to ~/.config/sway/config and it'll work out of the box. Otherwise, copy the sample configuration file to ~/.config/sway/config. It is usually located at /etc/sway/config. Run man 5 sway for information on the configuration.

Running

Run sway from a TTY. Some display managers may work but are not supported by sway (gdm is known to work fairly well).