alex/vello
1
0
Fork 0
mirror of https://github.com/italicsjenga/vello.git synced 2024-10-17 15:01:31 +11:00
Code Issues Packages Projects Releases Wiki Activity

Add debug label functions to ComputePass

Browse source
This commit is contained in:
Chad Brokaw 2022-05-04 01:56:16 -04:00
parent 867b97f41d
commit 41316ccd4b
2 changed files with 16 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
piet-gpu-hal/src/hub.rs
View file

@ -752,6 +752,16 @@ impl<'a> ComputePass<'a> {
self.cmd_buf.memory_barrier(); self.cmd_buf.memory_barrier();
} }
/// Begin a labeled section for debugging and profiling purposes.
pub unsafe fn begin_debug_label(&mut self, label: &str) {
self.cmd_buf.begin_debug_label(label);
}
/// End a section opened by `begin_debug_label`.
pub unsafe fn end_debug_label(&mut self) {
self.cmd_buf.end_debug_label();
}
pub unsafe fn end(self) { pub unsafe fn end(self) {
self.cmd_buf.cmd_buf().end_compute_pass(); self.cmd_buf.cmd_buf().end_compute_pass();
} }

19
piet-gpu/src/lib.rs
View file

@ -437,32 +437,30 @@ impl Renderer {
); );
pass.end(); pass.end();
cmd_buf.end_debug_label(); cmd_buf.end_debug_label();
// cmd_buf.write_timestamp(&query_pool, 1);
cmd_buf.memory_barrier(); cmd_buf.memory_barrier();
cmd_buf.begin_debug_label("Clip bounding box calculation");
let mut pass = cmd_buf.begin_compute_pass(&ComputePassDescriptor::timer(&query_pool, 2, 3)); let mut pass = cmd_buf.begin_compute_pass(&ComputePassDescriptor::timer(&query_pool, 2, 3));
pass.begin_debug_label("Clip bounding box calculation");
self.clip_binding self.clip_binding
.record(&mut pass, &self.clip_code, self.n_clip as u32); .record(&mut pass, &self.clip_code, self.n_clip as u32);
// cmd_buf.end_debug_label(); pass.end_debug_label();
// cmd_buf.begin_debug_label("Element binning"); pass.begin_debug_label("Element binning");
pass.dispatch( pass.dispatch(
&self.bin_pipeline, &self.bin_pipeline,
&self.bin_ds, &self.bin_ds,
(((self.n_paths + 255) / 256) as u32, 1, 1), (((self.n_paths + 255) / 256) as u32, 1, 1),
(256, 1, 1), (256, 1, 1),
); );
// cmd_buf.end_debug_label(); pass.end_debug_label();
pass.memory_barrier(); pass.memory_barrier();
// cmd_buf.begin_debug_label("Tile allocation"); pass.begin_debug_label("Tile allocation");
pass.dispatch( pass.dispatch(
&self.tile_pipeline, &self.tile_pipeline,
&self.tile_ds[buf_ix], &self.tile_ds[buf_ix],
(((self.n_paths + 255) / 256) as u32, 1, 1), (((self.n_paths + 255) / 256) as u32, 1, 1),
(256, 1, 1), (256, 1, 1),
); );
// cmd_buf.end_debug_label(); pass.end_debug_label();
pass.end(); pass.end();
// cmd_buf.write_timestamp(&query_pool, 2);
cmd_buf.begin_debug_label("Path flattening"); cmd_buf.begin_debug_label("Path flattening");
cmd_buf.memory_barrier(); cmd_buf.memory_barrier();
let mut pass = cmd_buf.begin_compute_pass(&ComputePassDescriptor::timer(&query_pool, 4, 5)); let mut pass = cmd_buf.begin_compute_pass(&ComputePassDescriptor::timer(&query_pool, 4, 5));
@ -473,7 +471,6 @@ impl Renderer {
(32, 1, 1), (32, 1, 1),
); );
pass.end(); pass.end();
// cmd_buf.write_timestamp(&query_pool, 3);
cmd_buf.end_debug_label(); cmd_buf.end_debug_label();
cmd_buf.memory_barrier(); cmd_buf.memory_barrier();
cmd_buf.begin_debug_label("Backdrop propagation"); cmd_buf.begin_debug_label("Backdrop propagation");
@ -485,10 +482,8 @@ impl Renderer {
(256, self.backdrop_y, 1), (256, self.backdrop_y, 1),
); );
pass.end(); pass.end();
// cmd_buf.write_timestamp(&query_pool, 4);
cmd_buf.end_debug_label(); cmd_buf.end_debug_label();
// TODO: redo query accounting // TODO: redo query accounting
// cmd_buf.write_timestamp(&query_pool, 5);
cmd_buf.memory_barrier(); cmd_buf.memory_barrier();
cmd_buf.begin_debug_label("Coarse raster"); cmd_buf.begin_debug_label("Coarse raster");
let mut pass = cmd_buf.begin_compute_pass(&ComputePassDescriptor::timer(&query_pool, 8, 9)); let mut pass = cmd_buf.begin_compute_pass(&ComputePassDescriptor::timer(&query_pool, 8, 9));
@ -504,7 +499,6 @@ impl Renderer {
); );
pass.end(); pass.end();
cmd_buf.end_debug_label(); cmd_buf.end_debug_label();
// cmd_buf.write_timestamp(&query_pool, 6);
cmd_buf.memory_barrier(); cmd_buf.memory_barrier();
cmd_buf.begin_debug_label("Fine raster"); cmd_buf.begin_debug_label("Fine raster");
let mut pass = let mut pass =
@ -521,7 +515,6 @@ impl Renderer {
); );
pass.end(); pass.end();
cmd_buf.end_debug_label(); cmd_buf.end_debug_label();
// cmd_buf.write_timestamp(&query_pool, 7);
cmd_buf.memory_barrier(); cmd_buf.memory_barrier();
cmd_buf.image_barrier(&self.image_dev, ImageLayout::General, ImageLayout::BlitSrc); cmd_buf.image_barrier(&self.image_dev, ImageLayout::General, ImageLayout::BlitSrc);
} }