alex/vello
1
0
Fork 0
mirror of https://github.com/italicsjenga/vello.git synced 2025-01-10 20:51:29 +11:00
Code Issues Packages Projects Releases Wiki Activity

Don't reset query pool twice

Browse source 
When invoked in non robust memory mode (ie not using RenderDriver), both
the render_coarse and render_fine calls reset the query pool, which in
turn causes the fetch of the query pool to hang (in Vulkan).

This is not an issue in robust memory mode because there are two
different query pools, and both should indeed be reset.

This patch makes the second reset conditional on the query pool being
fresh.

Fixes an observed hang with the xilem prototype on Windows.
This commit is contained in:
Raph Levien 2022-11-21 21:43:03 -08:00
parent 18c0da02e5
commit 433327cb34
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
piet-gpu/src/lib.rs
View file

@ -585,7 +585,9 @@ impl Renderer {
query_pool: &QueryPool, query_pool: &QueryPool,
query_start: u32, query_start: u32,
) { ) {
if query_start == 0 {
cmd_buf.reset_query_pool(&query_pool); cmd_buf.reset_query_pool(&query_pool);
}
cmd_buf.begin_debug_label("Fine raster"); cmd_buf.begin_debug_label("Fine raster");
let mut pass = cmd_buf.begin_compute_pass(&ComputePassDescriptor::timer( let mut pass = cmd_buf.begin_compute_pass(&ComputePassDescriptor::timer(
&query_pool, &query_pool,