alex/vello
1
0
Fork 0
mirror of https://github.com/italicsjenga/vello.git synced 2025-01-10 20:51:29 +11:00
Code Issues Packages Projects Releases Wiki Activity

backdrop: avoid a (benign) zero-sized read

Browse source 
Found with MEM_DEBUG added in later change.

Signed-off-by: Elias Naur <mail@eliasnaur.com>
This commit is contained in:
Elias Naur 2020-12-24 11:36:05 +01:00
parent c4f5a69a0d
commit 8b62022749
2 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
piet-gpu/shader/backdrop.comp
View file

@ -85,10 +85,11 @@ void main() {
el_ix = probe; el_ix = probe;
} }
} }
uint seq_ix = row - (el_ix > 0 ? sh_row_count[el_ix - 1] : 0);
uint width = sh_row_width[el_ix]; uint width = sh_row_width[el_ix];
if (width > 0) {
// Process one row sequentially // Process one row sequentially
// Read backdrop value per tile and prefix sum it // Read backdrop value per tile and prefix sum it
uint seq_ix = row - (el_ix > 0 ? sh_row_count[el_ix - 1] : 0);
uint tile_el_ix = sh_row_base[el_ix] + seq_ix * 2 * width; uint tile_el_ix = sh_row_base[el_ix] + seq_ix * 2 * width;
uint sum = memory[tile_el_ix]; uint sum = memory[tile_el_ix];
for (uint x = 1; x < width; x++) { for (uint x = 1; x < width; x++) {
@ -97,4 +98,5 @@ void main() {
memory[tile_el_ix] = sum; memory[tile_el_ix] = sum;
} }
} }
}
} }

BIN
piet-gpu/shader/backdrop.spv
View file

Binary file not shown.