alex/vello
1
0
Fork 0
mirror of https://github.com/italicsjenga/vello.git synced 2025-01-10 20:51:29 +11:00
Code Issues Packages Projects Releases Wiki Activity

piet-gpu/shader: delete unused is_fill from elements.comp

Browse source 
Delete debug code as well.

Signed-off-by: Elias Naur <mail@eliasnaur.com>
This commit is contained in:
Elias Naur 2020-10-14 10:43:16 +02:00
parent 61810b1bff
commit bc01180519
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
piet-gpu/shader/elements.comp
View file

@ -94,7 +94,7 @@ State combine_state(State a, State b) {
return c; return c;
} }
State map_element(ElementRef ref, inout bool is_fill) { State map_element(ElementRef ref) {
// TODO: it would *probably* be more efficient to make the memory read patterns less // TODO: it would *probably* be more efficient to make the memory read patterns less
// divergent, though it would be more wasted memory. // divergent, though it would be more wasted memory.
uint tag = Element_tag(ref); uint tag = Element_tag(ref);
@ -106,7 +106,6 @@ State map_element(ElementRef ref, inout bool is_fill) {
c.flags = 0; c.flags = 0;
c.path_count = 0; c.path_count = 0;
c.pathseg_count = 0; c.pathseg_count = 0;
is_fill = false;
switch (tag) { switch (tag) {
case Element_FillLine: case Element_FillLine:
case Element_StrokeLine: case Element_StrokeLine:
@ -132,8 +131,6 @@ State map_element(ElementRef ref, inout bool is_fill) {
case Element_Fill: case Element_Fill:
case Element_FillMask: case Element_FillMask:
case Element_FillMaskInv: case Element_FillMaskInv:
is_fill = true;
// fall-through
case Element_Stroke: case Element_Stroke:
c.flags = FLAG_RESET_BBOX; c.flags = FLAG_RESET_BBOX;
c.path_count = 1; c.path_count = 1;
@ -185,12 +182,11 @@ void main() {
uint ix = part_ix * PARTITION_SIZE + gl_LocalInvocationID.x * N_ROWS; uint ix = part_ix * PARTITION_SIZE + gl_LocalInvocationID.x * N_ROWS;
ElementRef ref = ElementRef(ix * Element_size); ElementRef ref = ElementRef(ix * Element_size);
bool is_fill; th_state[0] = map_element(ref);
th_state[0] = map_element(ref, is_fill);
for (uint i = 1; i < N_ROWS; i++) { for (uint i = 1; i < N_ROWS; i++) {
// discussion question: would it be faster to load using more coherent patterns // discussion question: would it be faster to load using more coherent patterns
// into thread memory? This is kinda strided. // into thread memory? This is kinda strided.
th_state[i] = combine_state(th_state[i - 1], map_element(Element_index(ref, i), is_fill)); th_state[i] = combine_state(th_state[i - 1], map_element(Element_index(ref, i)));
} }
State agg = th_state[N_ROWS - 1]; State agg = th_state[N_ROWS - 1];
sh_mat[gl_LocalInvocationID.x] = agg.mat; sh_mat[gl_LocalInvocationID.x] = agg.mat;