alex/vello
1
0
Fork 0
mirror of https://github.com/italicsjenga/vello.git synced 2025-01-10 12:41:30 +11:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #200 from dfrg/pathfix

Browse source 
More robust path encoding
This commit is contained in:
Chad Brokaw 2022-11-08 11:33:47 -05:00 committed by GitHub
parent 1b84071d33 b2d57872d9
commit c5dbf7612c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 77 additions and 65 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
piet-gpu/bin/winit.rs
View file

@ -126,7 +126,7 @@ fn main() -> Result<(), Error> {
} else {
let mut builder = SceneBuilder::for_scene(&mut scene);
const N_SAMPLES: usize = 5;
const N_SAMPLES: usize = 6;
match sample_index % N_SAMPLES {
0 => samples::render_anim_frame(
&mut builder,
@ -136,6 +136,7 @@ fn main() -> Result<(), Error> {
1 => samples::render_blend_grid(&mut builder),
2 => samples::render_tiger(&mut builder, false),
3 => samples::render_brush_transform(&mut builder, current_frame),
4 => samples::render_funky_paths(&mut builder),
_ => samples::render_scene(&mut builder),
}
render_info(&mut simple_text, &mut builder, &info_string);

41
piet-gpu/src/samples.rs
View file

@ -4,6 +4,47 @@ use piet_scene::*;
use crate::SimpleText;
pub fn render_funky_paths(sb: &mut SceneBuilder) {
use PathElement::*;
let missing_movetos = [
LineTo((100.0, 100.0).into()),
LineTo((100.0, 200.0).into()),
Close,
LineTo((0.0, 400.0).into()),
LineTo((100.0, 400.0).into()),
];
let only_movetos = [MoveTo((0.0, 0.0).into()), MoveTo((100.0, 100.0).into())];
let empty: [PathElement; 0] = [];
sb.fill(
Fill::NonZero,
Affine::translate(100.0, 100.0),
&Color::rgb8(0, 0, 255).into(),
None,
missing_movetos,
);
sb.fill(
Fill::NonZero,
Affine::IDENTITY,
&Color::rgb8(0, 0, 255).into(),
None,
empty,
);
sb.fill(
Fill::NonZero,
Affine::IDENTITY,
&Color::rgb8(0, 0, 255).into(),
None,
only_movetos,
);
sb.stroke(
&simple_stroke(8.0),
Affine::translate(100.0, 100.0),
&Color::rgb8(0, 255, 255).into(),
None,
missing_movetos,
);
}
#[allow(unused)]
const N_CIRCLES: usize = 0;

7
piet-gpu/src/simple_text.rs
View file

@ -67,13 +67,10 @@ impl SimpleText {
.unwrap_or(default_advance) as f32
* scale;
if let Some(glyph) = provider.get(gid, brush) {
if !glyph.is_empty() {
let xform = transform
* Affine::translate(pen_x, 0.0)
* Affine::scale(1.0, -1.0);
let xform =
transform * Affine::translate(pen_x, 0.0) * Affine::scale(1.0, -1.0);
builder.append(&glyph, Some(xform));
}
}
pen_x += advance;
}
}

81
piet-scene/src/scene/builder.rs
View file

@ -146,45 +146,28 @@ impl<'a> SceneBuilder<'a> {
E: Iterator,
E::Item: Borrow<PathElement>,
{
if is_fill {
self.encode_path_inner(
elements
.map(|el| *el.borrow())
.flat_map(|el| {
match el {
PathElement::MoveTo(..) => Some(PathElement::Close),
_ => None,
}
.into_iter()
.chain(Some(el))
})
.chain(Some(PathElement::Close)),
)
} else {
self.encode_path_inner(elements.map(|el| *el.borrow()))
}
}
fn encode_path_inner(&mut self, elements: impl Iterator<Item = PathElement>) -> bool {
let mut b = PathBuilder::new(&mut self.scene.tag_stream, &mut self.scene.pathseg_stream);
let mut has_els = false;
let mut b = PathBuilder::new(
&mut self.scene.tag_stream,
&mut self.scene.pathseg_stream,
is_fill,
);
for el in elements {
match el {
match el.borrow() {
PathElement::MoveTo(p0) => b.move_to(p0.x, p0.y),
PathElement::LineTo(p0) => b.line_to(p0.x, p0.y),
PathElement::QuadTo(p0, p1) => b.quad_to(p0.x, p0.y, p1.x, p1.y),
PathElement::CurveTo(p0, p1, p2) => b.cubic_to(p0.x, p0.y, p1.x, p1.y, p2.x, p2.y),
PathElement::Close => b.close_path(),
}
has_els = true;
}
if has_els {
b.path();
let n_pathseg = b.n_pathseg();
b.finish();
if b.n_pathseg != 0 {
self.scene.n_path += 1;
self.scene.n_pathseg += n_pathseg;
self.scene.n_pathseg += b.n_pathseg;
true
} else {
false
}
has_els
}
fn maybe_encode_transform(&mut self, transform: Affine) {
@ -345,6 +328,7 @@ struct PathBuilder<'a> {
first_pt: [f32; 2],
state: PathState,
n_pathseg: u32,
is_fill: bool,
}
#[derive(PartialEq)]
@ -355,25 +339,28 @@ enum PathState {
}
impl<'a> PathBuilder<'a> {
pub fn new(tags: &'a mut Vec<u8>, pathsegs: &'a mut Vec<u8>) -> PathBuilder<'a> {
pub fn new(tags: &'a mut Vec<u8>, pathsegs: &'a mut Vec<u8>, is_fill: bool) -> PathBuilder<'a> {
PathBuilder {
tag_stream: tags,
pathseg_stream: pathsegs,
first_pt: [0.0, 0.0],
state: PathState::Start,
n_pathseg: 0,
is_fill,
}
}
pub fn move_to(&mut self, x: f32, y: f32) {
if self.is_fill {
self.close_path();
}
let buf = [x, y];
let bytes = bytemuck::bytes_of(&buf);
self.first_pt = buf;
if self.state == PathState::MoveTo {
let new_len = self.pathseg_stream.len() - 8;
self.pathseg_stream.truncate(new_len);
}
if self.state == PathState::NonemptySubpath {
} else if self.state == PathState::NonemptySubpath {
if let Some(tag) = self.tag_stream.last_mut() {
*tag |= 4;
}
@ -384,8 +371,7 @@ impl<'a> PathBuilder<'a> {
pub fn line_to(&mut self, x: f32, y: f32) {
if self.state == PathState::Start {
// should warn or error
return;
self.move_to(self.first_pt[0], self.first_pt[1]);
}
let buf = [x, y];
let bytes = bytemuck::bytes_of(&buf);
@ -397,7 +383,7 @@ impl<'a> PathBuilder<'a> {
pub fn quad_to(&mut self, x1: f32, y1: f32, x2: f32, y2: f32) {
if self.state == PathState::Start {
return;
self.move_to(self.first_pt[0], self.first_pt[1]);
}
let buf = [x1, y1, x2, y2];
let bytes = bytemuck::bytes_of(&buf);
@ -409,7 +395,7 @@ impl<'a> PathBuilder<'a> {
pub fn cubic_to(&mut self, x1: f32, y1: f32, x2: f32, y2: f32, x3: f32, y3: f32) {
if self.state == PathState::Start {
return;
self.move_to(self.first_pt[0], self.first_pt[1]);
}
let buf = [x1, y1, x2, y2, x3, y3];
let bytes = bytemuck::bytes_of(&buf);
@ -448,32 +434,19 @@ impl<'a> PathBuilder<'a> {
self.state = PathState::Start;
}
fn finish(&mut self) {
pub fn finish(&mut self) {
if self.is_fill {
self.close_path();
}
if self.state == PathState::MoveTo {
let new_len = self.pathseg_stream.len() - 8;
self.pathseg_stream.truncate(new_len);
}
if self.n_pathseg != 0 {
if let Some(tag) = self.tag_stream.last_mut() {
*tag |= 4;
}
}
/// Finish encoding a path.
///
/// Encode this after encoding path segments.
pub fn path(&mut self) {
self.finish();
// maybe don't encode if path is empty? might throw off sync though
self.tag_stream.push(0x10);
}
/// Get the number of path segments.
///
/// This is the number of path segments that will be written by the
/// path stage; use this for allocating the output buffer.
///
/// Also note: it takes `self` for lifetime reasons.
pub fn n_pathseg(self) -> u32 {
self.n_pathseg
}
}