alex/vello
1
0
Fork 0
mirror of https://github.com/italicsjenga/vello.git synced 2025-01-10 12:41:30 +11:00
Code Issues Packages Projects Releases Wiki Activity

coarse.comp: don't write Cmd_End to tiles out of bounds

Browse source 
If WIDTH_IN_TILES or HEIGHT_IN_TILES are not divisible by N_TILE_X or N_TILE_Y
respectively, the previously unconditional Cmd_End_write would write out of
bounds.

Signed-off-by: Elias Naur <mail@eliasnaur.com>
This commit is contained in:
Elias Naur 2020-12-18 00:29:25 +01:00
parent 4de67d9081
commit c67696714b
3 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
piet-gpu/shader/coarse.comp
View file

@ -370,5 +370,7 @@ void main() {
rd_ix += N_TILE;
if (rd_ix >= ready_ix && partition_ix >= n_partitions) break;
}
Cmd_End_write(cmd_ref);
if (bin_tile_x + tile_x < WIDTH_IN_TILES && bin_tile_y + tile_y < HEIGHT_IN_TILES) {
Cmd_End_write(cmd_ref);
}
}

BIN
piet-gpu/shader/coarse.spv
View file

Binary file not shown.

2
piet-gpu/src/lib.rs
View file

@ -404,7 +404,7 @@ impl Renderer {
cmd_buf.dispatch(
&self.coarse_pipeline,
&self.coarse_ds,
(WIDTH as u32 / 256, HEIGHT as u32 / 256, 1),
((WIDTH as u32 + 255) / 256, (HEIGHT as u32 + 255) / 256, 1),
);
cmd_buf.write_timestamp(&query_pool, 6);
cmd_buf.memory_barrier();