diff --git a/examples/child_window.rs b/examples/child_window.rs index 775c180c..65135b79 100644 --- a/examples/child_window.rs +++ b/examples/child_window.rs @@ -3,7 +3,7 @@ mod fill; #[cfg(any(x11_platform, macos_platform, windows_platform))] -fn main() { +fn main() -> Result<(), impl std::error::Error> { use std::collections::HashMap; use raw_window_handle::HasRawWindowHandle; diff --git a/examples/control_flow.rs b/examples/control_flow.rs index fd39d476..49f00a0d 100644 --- a/examples/control_flow.rs +++ b/examples/control_flow.rs @@ -27,7 +27,7 @@ enum Mode { const WAIT_TIME: time::Duration = time::Duration::from_millis(100); const POLL_SLEEP_TIME: time::Duration = time::Duration::from_millis(100); -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); println!("Press '1' to switch to Wait mode."); @@ -122,5 +122,5 @@ fn main() { } _ => (), } - }); + }) } diff --git a/examples/cursor.rs b/examples/cursor.rs index c9edf2a0..e7d3b9d5 100644 --- a/examples/cursor.rs +++ b/examples/cursor.rs @@ -10,7 +10,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -54,7 +54,7 @@ fn main() { } _ => (), } - }); + }) } const CURSORS: &[CursorIcon] = &[ diff --git a/examples/cursor_grab.rs b/examples/cursor_grab.rs index 72ba14e5..b69ab47c 100644 --- a/examples/cursor_grab.rs +++ b/examples/cursor_grab.rs @@ -11,7 +11,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -73,5 +73,5 @@ fn main() { Event::RedrawRequested(_) => fill::fill_window(&window), _ => (), } - }); + }) } diff --git a/examples/custom_events.rs b/examples/custom_events.rs index b3a3d217..2e8f5472 100644 --- a/examples/custom_events.rs +++ b/examples/custom_events.rs @@ -1,7 +1,7 @@ #![allow(clippy::single_match)] #[cfg(not(wasm_platform))] -fn main() { +fn main() -> Result<(), impl std::error::Error> { use simple_logger::SimpleLogger; use winit::{ event::{Event, WindowEvent}, @@ -52,7 +52,7 @@ fn main() { } _ => (), } - }); + }) } #[cfg(wasm_platform)] diff --git a/examples/drag_window.rs b/examples/drag_window.rs index af5c824d..55056001 100644 --- a/examples/drag_window.rs +++ b/examples/drag_window.rs @@ -11,7 +11,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -69,7 +69,7 @@ fn main() { } } _ => (), - }); + }) } fn name_windows(window_id: WindowId, switched: bool, window_1: &Window, window_2: &Window) { diff --git a/examples/fullscreen.rs b/examples/fullscreen.rs index e38390eb..9bfa3fd6 100644 --- a/examples/fullscreen.rs +++ b/examples/fullscreen.rs @@ -12,7 +12,7 @@ use winit::platform::macos::WindowExtMacOS; #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -131,5 +131,5 @@ fn main() { } _ => {} } - }); + }) } diff --git a/examples/handling_close.rs b/examples/handling_close.rs index c5d95471..5fa90283 100644 --- a/examples/handling_close.rs +++ b/examples/handling_close.rs @@ -11,7 +11,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -87,5 +87,5 @@ fn main() { } _ => (), } - }); + }) } diff --git a/examples/ime.rs b/examples/ime.rs index d108c8fc..319e0615 100644 --- a/examples/ime.rs +++ b/examples/ime.rs @@ -13,7 +13,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new() .with_level(LevelFilter::Trace) .init() @@ -105,5 +105,5 @@ fn main() { } _ => (), } - }); + }) } diff --git a/examples/key_binding.rs b/examples/key_binding.rs index 7d4968f3..ef5d5319 100644 --- a/examples/key_binding.rs +++ b/examples/key_binding.rs @@ -17,7 +17,7 @@ fn main() { } #[cfg(any(target_os = "macos", target_os = "windows", target_os = "linux"))] -fn main() { +fn main() -> Result<(), impl std::error::Error> { #[path = "util/fill.rs"] mod fill; @@ -61,5 +61,5 @@ fn main() { } _ => (), }; - }); + }) } diff --git a/examples/mouse_wheel.rs b/examples/mouse_wheel.rs index ea0c962b..38d06aff 100644 --- a/examples/mouse_wheel.rs +++ b/examples/mouse_wheel.rs @@ -10,7 +10,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -64,5 +64,5 @@ In other words, the deltas indicate the direction in which to move the content ( } _ => (), } - }); + }) } diff --git a/examples/multithreaded.rs b/examples/multithreaded.rs index cc427636..bd9f9004 100644 --- a/examples/multithreaded.rs +++ b/examples/multithreaded.rs @@ -1,7 +1,7 @@ #![allow(clippy::single_match)] #[cfg(not(wasm_platform))] -fn main() { +fn main() -> Result<(), impl std::error::Error> { use std::{collections::HashMap, sync::mpsc, thread, time::Duration}; use simple_logger::SimpleLogger; diff --git a/examples/multiwindow.rs b/examples/multiwindow.rs index 03812afc..7fcb724b 100644 --- a/examples/multiwindow.rs +++ b/examples/multiwindow.rs @@ -13,7 +13,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); diff --git a/examples/request_redraw.rs b/examples/request_redraw.rs index 16ec6ca7..a064cd39 100644 --- a/examples/request_redraw.rs +++ b/examples/request_redraw.rs @@ -10,7 +10,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -41,5 +41,5 @@ fn main() { } _ => (), } - }); + }) } diff --git a/examples/request_redraw_threaded.rs b/examples/request_redraw_threaded.rs index afe87497..2010f96e 100644 --- a/examples/request_redraw_threaded.rs +++ b/examples/request_redraw_threaded.rs @@ -1,7 +1,7 @@ #![allow(clippy::single_match)] #[cfg(not(wasm_platform))] -fn main() { +fn main() -> Result<(), impl std::error::Error> { use std::{sync::Arc, thread, time}; use simple_logger::SimpleLogger; @@ -49,7 +49,7 @@ fn main() { } _ => (), } - }); + }) } #[cfg(wasm_platform)] diff --git a/examples/resizable.rs b/examples/resizable.rs index b0c0f6ea..ecec14b2 100644 --- a/examples/resizable.rs +++ b/examples/resizable.rs @@ -12,7 +12,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -53,5 +53,5 @@ fn main() { } _ => (), }; - }); + }) } diff --git a/examples/startup_notification.rs b/examples/startup_notification.rs index 5de61401..fdd68d51 100644 --- a/examples/startup_notification.rs +++ b/examples/startup_notification.rs @@ -1,9 +1,5 @@ //! Demonstrates the use of startup notifications on Linux. -fn main() { - example::main(); -} - #[cfg(any(x11_platform, wayland_platform))] #[path = "./util/fill.rs"] mod fill; @@ -21,7 +17,7 @@ mod example { }; use winit::window::{Window, WindowBuilder, WindowId}; - pub(super) fn main() { + pub(super) fn main() -> Result<(), impl std::error::Error> { // Create the event loop and get the activation token. let event_loop = EventLoop::new(); let mut current_token = match event_loop.read_token_from_env() { @@ -115,13 +111,16 @@ mod example { } flow.set_wait(); - }); + }) } } -#[cfg(not(any(x11_platform, wayland_platform)))] -mod example { - pub(super) fn main() { - println!("This example is only supported on X11 and Wayland platforms."); - } +#[cfg(any(x11_platform, wayland_platform))] +fn main() -> Result<(), impl std::error::Error> { + example::main() +} + +#[cfg(not(any(x11_platform, wayland_platform)))] +fn main() { + println!("This example is only supported on X11 and Wayland platforms."); } diff --git a/examples/theme.rs b/examples/theme.rs index 7b132a9d..b3dac443 100644 --- a/examples/theme.rs +++ b/examples/theme.rs @@ -11,7 +11,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -75,5 +75,5 @@ fn main() { } _ => (), } - }); + }) } diff --git a/examples/timer.rs b/examples/timer.rs index 273cc638..13fceb51 100644 --- a/examples/timer.rs +++ b/examples/timer.rs @@ -16,7 +16,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -47,5 +47,5 @@ fn main() { } _ => (), } - }); + }) } diff --git a/examples/touchpad_gestures.rs b/examples/touchpad_gestures.rs index 2ebe8362..0cca2c2c 100644 --- a/examples/touchpad_gestures.rs +++ b/examples/touchpad_gestures.rs @@ -8,7 +8,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -47,5 +47,5 @@ fn main() { } else if let Event::RedrawRequested(_) = event { fill::fill_window(&window); } - }); + }) } diff --git a/examples/transparent.rs b/examples/transparent.rs index 134be3ad..b093867d 100644 --- a/examples/transparent.rs +++ b/examples/transparent.rs @@ -10,7 +10,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -36,5 +36,5 @@ fn main() { } _ => (), } - }); + }) } diff --git a/examples/web.rs b/examples/web.rs index f2033d6d..1e406764 100644 --- a/examples/web.rs +++ b/examples/web.rs @@ -7,7 +7,7 @@ use winit::{ window::{Fullscreen, WindowBuilder}, }; -pub fn main() { +pub fn main() -> Result<(), impl std::error::Error> { let event_loop = EventLoop::new(); let builder = WindowBuilder::new().with_title("A fantastic window!"); @@ -56,7 +56,7 @@ pub fn main() { } _ => (), } - }); + }) } #[cfg(wasm_platform)] @@ -72,7 +72,7 @@ mod wasm { console_log::init_with_level(log::Level::Debug).expect("error initializing logger"); #[allow(clippy::main_recursion)] - super::main(); + let _ = super::main(); } pub fn insert_canvas_and_create_log_list(window: &Window) -> web_sys::Element { diff --git a/examples/web_aspect_ratio.rs b/examples/web_aspect_ratio.rs index b965f507..e0f5ba16 100644 --- a/examples/web_aspect_ratio.rs +++ b/examples/web_aspect_ratio.rs @@ -47,7 +47,7 @@ This example demonstrates the desired future functionality which will possibly b // Render once with the size info we currently have render_circle(&canvas, window.inner_size()); - event_loop.run(move |event, _, control_flow| { + let _ = event_loop.run(move |event, _, control_flow| { *control_flow = ControlFlow::Wait; match event { diff --git a/examples/window.rs b/examples/window.rs index 4a5d8b00..d2764c2a 100644 --- a/examples/window.rs +++ b/examples/window.rs @@ -10,7 +10,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -37,5 +37,5 @@ fn main() { } _ => (), } - }); + }) } diff --git a/examples/window_buttons.rs b/examples/window_buttons.rs index 1f28412c..b531531c 100644 --- a/examples/window_buttons.rs +++ b/examples/window_buttons.rs @@ -14,7 +14,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -71,5 +71,5 @@ fn main() { } _ => (), } - }); + }) } diff --git a/examples/window_debug.rs b/examples/window_debug.rs index d1b3ba3d..5c7f2326 100644 --- a/examples/window_debug.rs +++ b/examples/window_debug.rs @@ -14,7 +14,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -139,5 +139,5 @@ fn main() { } _ => (), } - }); + }) } diff --git a/examples/window_drag_resize.rs b/examples/window_drag_resize.rs index 277e7d4c..3232c4c8 100644 --- a/examples/window_drag_resize.rs +++ b/examples/window_drag_resize.rs @@ -13,7 +13,7 @@ const BORDER: f64 = 8.0; #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -74,7 +74,7 @@ fn main() { fill::fill_window(&window); } _ => (), - }); + }) } fn cursor_direction_icon(resize_direction: Option) -> CursorIcon { diff --git a/examples/window_icon.rs b/examples/window_icon.rs index e87372c2..6e65f348 100644 --- a/examples/window_icon.rs +++ b/examples/window_icon.rs @@ -12,7 +12,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); // You'll have to choose an icon size at your own discretion. On X11, the desired size varies @@ -48,7 +48,7 @@ fn main() { } else if let Event::RedrawRequested(_) = event { fill::fill_window(&window); } - }); + }) } fn load_icon(path: &Path) -> Icon { diff --git a/examples/window_option_as_alt.rs b/examples/window_option_as_alt.rs index fc2e4582..6d7792b5 100644 --- a/examples/window_option_as_alt.rs +++ b/examples/window_option_as_alt.rs @@ -18,7 +18,7 @@ mod fill; /// Prints the keyboard events characters received when option_is_alt is true versus false. /// A left mouse click will toggle option_is_alt. #[cfg(target_os = "macos")] -fn main() { +fn main() -> Result<(), impl std::error::Error> { let event_loop = EventLoop::new(); let window = WindowBuilder::new() @@ -66,7 +66,7 @@ fn main() { } _ => (), } - }); + }) } #[cfg(not(target_os = "macos"))] diff --git a/examples/window_resize_increments.rs b/examples/window_resize_increments.rs index 1c713ba7..42a42018 100644 --- a/examples/window_resize_increments.rs +++ b/examples/window_resize_increments.rs @@ -11,7 +11,7 @@ use winit::{ #[path = "util/fill.rs"] mod fill; -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); @@ -60,5 +60,5 @@ fn main() { } _ => (), } - }); + }) } diff --git a/examples/window_tabbing.rs b/examples/window_tabbing.rs index d2640335..1989a8f3 100644 --- a/examples/window_tabbing.rs +++ b/examples/window_tabbing.rs @@ -19,7 +19,7 @@ use winit::{ mod fill; #[cfg(target_os = "macos")] -fn main() { +fn main() -> Result<(), impl std::error::Error> { SimpleLogger::new().init().unwrap(); let event_loop = EventLoop::new(); diff --git a/src/event_loop.rs b/src/event_loop.rs index 7e5a66f7..87ec9535 100644 --- a/src/event_loop.rs +++ b/src/event_loop.rs @@ -18,6 +18,7 @@ use std::time::{Duration, Instant}; #[cfg(wasm_platform)] use web_time::{Duration, Instant}; +use crate::error::RunLoopError; use crate::{event::Event, monitor::MonitorHandle, platform_impl}; /// Provides a way to retrieve events from the system and from the windows that were registered to @@ -285,23 +286,33 @@ impl EventLoop { EventLoopBuilder::::with_user_event().build() } - /// Hijacks the calling thread and initializes the winit event loop with the provided - /// closure. Since the closure is `'static`, it must be a `move` closure if it needs to + /// Runs the event loop in the calling thread and calls the given `event_handler` closure + /// to dispatch any pending events. + /// + /// Since the closure is `'static`, it must be a `move` closure if it needs to /// access any data from the calling context. /// /// See the [`ControlFlow`] docs for information on how changes to `&mut ControlFlow` impact the /// event loop's behavior. /// - /// Any values not passed to this function will *not* be dropped. - /// /// ## Platform-specific /// /// - **X11 / Wayland:** The program terminates with exit code 1 if the display server /// disconnects. + /// - **iOS:** Will never return to the caller and so values not passed to this function will + /// *not* be dropped before the process exits. + /// - **Web:** Will _act_ as if it never returns to the caller by throwing a Javascript exception + /// (that Rust doesn't see) that will also mean that the rest of the function is never executed + /// and any values not passed to this function will *not* be dropped. + /// + /// Web applications are recommended to use `spawn()` instead of `run()` to avoid the need + /// for the Javascript exception trick, and to make it clearer that the event loop runs + /// asynchronously (via the browser's own, internal, event loop) and doesn't block the + /// current thread of execution like it does on other platforms. /// /// [`ControlFlow`]: crate::event_loop::ControlFlow #[inline] - pub fn run(self, event_handler: F) -> ! + pub fn run(self, event_handler: F) -> Result<(), RunLoopError> where F: 'static + FnMut(Event<'_, T>, &EventLoopWindowTarget, &mut ControlFlow), { diff --git a/src/platform_impl/android/mod.rs b/src/platform_impl/android/mod.rs index cb45db05..3d449bdb 100644 --- a/src/platform_impl/android/mod.rs +++ b/src/platform_impl/android/mod.rs @@ -526,17 +526,12 @@ impl EventLoop { self.pending_redraw = pending_redraw; } - pub fn run(mut self, event_handler: F) -> ! + pub fn run(mut self, event_handler: F) -> Result<(), RunLoopError> where F: 'static + FnMut(event::Event<'_, T>, &event_loop::EventLoopWindowTarget, &mut ControlFlow), { - let exit_code = match self.run_ondemand(event_handler) { - Err(RunLoopError::ExitFailure(code)) => code, - Err(_err) => 1, - Ok(_) => 0, - }; - ::std::process::exit(exit_code); + self.run_ondemand(event_handler) } pub fn run_ondemand(&mut self, mut event_handler: F) -> Result<(), RunLoopError> diff --git a/src/platform_impl/linux/mod.rs b/src/platform_impl/linux/mod.rs index b4e77dc9..35cead75 100644 --- a/src/platform_impl/linux/mod.rs +++ b/src/platform_impl/linux/mod.rs @@ -830,11 +830,11 @@ impl EventLoop { x11_or_wayland!(match self; EventLoop(evlp) => evlp.create_proxy(); as EventLoopProxy) } - pub fn run(self, callback: F) -> ! + pub fn run(mut self, callback: F) -> Result<(), RunLoopError> where - F: 'static + FnMut(crate::event::Event<'_, T>, &RootELW, &mut ControlFlow), + F: FnMut(crate::event::Event<'_, T>, &RootELW, &mut ControlFlow), { - x11_or_wayland!(match self; EventLoop(evlp) => evlp.run(callback)) + self.run_ondemand(callback) } pub fn run_ondemand(&mut self, callback: F) -> Result<(), RunLoopError> diff --git a/src/platform_impl/linux/wayland/event_loop/mod.rs b/src/platform_impl/linux/wayland/event_loop/mod.rs index 7bd04d9b..afe7c3e5 100644 --- a/src/platform_impl/linux/wayland/event_loop/mod.rs +++ b/src/platform_impl/linux/wayland/event_loop/mod.rs @@ -145,18 +145,6 @@ impl EventLoop { Ok(event_loop) } - pub fn run(mut self, callback: F) -> ! - where - F: FnMut(Event<'_, T>, &RootEventLoopWindowTarget, &mut ControlFlow) + 'static, - { - let exit_code = match self.run_ondemand(callback) { - Err(RunLoopError::ExitFailure(code)) => code, - Err(_err) => 1, - Ok(_) => 0, - }; - ::std::process::exit(exit_code) - } - pub fn run_ondemand(&mut self, mut event_handler: F) -> Result<(), RunLoopError> where F: FnMut(Event<'_, T>, &RootEventLoopWindowTarget, &mut ControlFlow), diff --git a/src/platform_impl/linux/x11/mod.rs b/src/platform_impl/linux/x11/mod.rs index 81929519..c6381288 100644 --- a/src/platform_impl/linux/x11/mod.rs +++ b/src/platform_impl/linux/x11/mod.rs @@ -432,18 +432,6 @@ impl EventLoop { &self.target } - pub fn run(mut self, callback: F) -> ! - where - F: FnMut(Event<'_, T>, &RootELW, &mut ControlFlow) + 'static, - { - let exit_code = match self.run_ondemand(callback) { - Err(RunLoopError::ExitFailure(code)) => code, - Err(_err) => 1, - Ok(_) => 0, - }; - ::std::process::exit(exit_code) - } - pub fn run_ondemand(&mut self, mut event_handler: F) -> Result<(), RunLoopError> where F: FnMut(Event<'_, T>, &RootELW, &mut ControlFlow), diff --git a/src/platform_impl/macos/event_loop.rs b/src/platform_impl/macos/event_loop.rs index e058259a..23743859 100644 --- a/src/platform_impl/macos/event_loop.rs +++ b/src/platform_impl/macos/event_loop.rs @@ -6,7 +6,7 @@ use std::{ mem, os::raw::c_void, panic::{catch_unwind, resume_unwind, AssertUnwindSafe, RefUnwindSafe, UnwindSafe}, - process, ptr, + ptr, rc::{Rc, Weak}, sync::mpsc, }; @@ -192,16 +192,11 @@ impl EventLoop { &self.window_target } - pub fn run(mut self, callback: F) -> ! + pub fn run(mut self, callback: F) -> Result<(), RunLoopError> where F: 'static + FnMut(Event<'_, T>, &RootWindowTarget, &mut ControlFlow), { - let exit_code = match self.run_ondemand(callback) { - Err(RunLoopError::ExitFailure(code)) => code, - Err(_err) => 1, - Ok(_) => 0, - }; - process::exit(exit_code); + self.run_ondemand(callback) } // NB: we don't base this on `pump_events` because for `MacOs` we can't support diff --git a/src/platform_impl/orbital/event_loop.rs b/src/platform_impl/orbital/event_loop.rs index 0b23e5d5..365c2d0f 100644 --- a/src/platform_impl/orbital/event_loop.rs +++ b/src/platform_impl/orbital/event_loop.rs @@ -12,6 +12,7 @@ use orbclient::{ use raw_window_handle::{OrbitalDisplayHandle, RawDisplayHandle}; use crate::{ + error::RunLoopError, event::{self, Ime, Modifiers, StartCause}, event_loop::{self, ControlFlow}, keyboard::{ @@ -442,7 +443,7 @@ impl EventLoop { } } - pub fn run(mut self, event_handler: F) -> ! + pub fn run(mut self, mut event_handler_inner: F) -> Result<(), RunLoopError> where F: 'static + FnMut(event::Event<'_, T>, &event_loop::EventLoopWindowTarget, &mut ControlFlow), @@ -688,7 +689,11 @@ impl EventLoop { &mut control_flow, ); - ::std::process::exit(code); + if code == 0 { + Ok(()) + } else { + Err(RunLoopError::ExitFailure(code)) + } } pub fn window_target(&self) -> &event_loop::EventLoopWindowTarget { diff --git a/src/platform_impl/windows/event_loop.rs b/src/platform_impl/windows/event_loop.rs index 7c45cbac..3fa14cbb 100644 --- a/src/platform_impl/windows/event_loop.rs +++ b/src/platform_impl/windows/event_loop.rs @@ -243,16 +243,11 @@ impl EventLoop { &self.window_target } - pub fn run(mut self, event_handler: F) -> ! + pub fn run(mut self, event_handler: F) -> Result<(), RunLoopError> where F: 'static + FnMut(Event<'_, T>, &RootELW, &mut ControlFlow), { - let exit_code = match self.run_ondemand(event_handler) { - Err(RunLoopError::ExitFailure(code)) => code, - Err(_err) => 1, - Ok(_) => 0, - }; - ::std::process::exit(exit_code); + self.run_ondemand(event_handler) } pub fn run_ondemand(&mut self, mut event_handler: F) -> Result<(), RunLoopError>