From b9a6366f96e14e396452da443b64a10ee480fabf Mon Sep 17 00:00:00 2001 From: Pierre Krieger Date: Mon, 29 Dec 2014 22:56:15 +0100 Subject: [PATCH] Update for changes in Send/Sync traits --- Cargo.toml | 4 ++-- src/android/mod.rs | 8 ++++++++ src/osx/headless.rs | 3 +++ src/osx/mod.rs | 5 +++++ src/win32/init.rs | 8 +++++++- src/win32/mod.rs | 11 ++++++++++- src/x11/headless.rs | 3 +++ src/x11/window/mod.rs | 3 +++ 8 files changed, 41 insertions(+), 4 deletions(-) diff --git a/Cargo.toml b/Cargo.toml index 99a727bb..71595b3a 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -38,9 +38,9 @@ git = "https://github.com/servo/rust-core-graphics" git = "https://github.com/servo/rust-core-graphics" [target.i686-pc-windows-gnu.dependencies.winapi] -version = "^0.0.2" +version = "^0.0.3" features = ["gdi32", "kernel32", "user32"] [target.x86_64-pc-windows-gnu.dependencies.winapi] -version = "^0.0.2" +version = "^0.0.3" features = ["gdi32", "kernel32", "user32"] diff --git a/src/android/mod.rs b/src/android/mod.rs index 7279f991..111d4b42 100644 --- a/src/android/mod.rs +++ b/src/android/mod.rs @@ -60,6 +60,11 @@ impl HeadlessContext { } } +#[cfg(feature = "headless")] +unsafe impl Send for HeadlessContext {} +#[cfg(feature = "headless")] +unsafe impl Sync for HeadlessContext {} + impl Window { pub fn new(builder: WindowBuilder) -> Result { use std::{mem, ptr}; @@ -275,6 +280,9 @@ impl Window { } } +unsafe impl Send for Window {} +unsafe impl Sync for Window {} + #[cfg(feature = "window")] #[deriving(Clone)] pub struct WindowProxy; diff --git a/src/osx/headless.rs b/src/osx/headless.rs index bbe3d9f5..1332cf31 100644 --- a/src/osx/headless.rs +++ b/src/osx/headless.rs @@ -99,6 +99,9 @@ impl HeadlessContext { } } +unsafe impl Send for HeadlessContext {} +unsafe impl Sync for HeadlessContext {} + impl Drop for HeadlessContext { fn drop(&mut self) { unsafe { diff --git a/src/osx/mod.rs b/src/osx/mod.rs index 7df66039..92ef641d 100644 --- a/src/osx/mod.rs +++ b/src/osx/mod.rs @@ -72,6 +72,11 @@ impl Window { } } +#[cfg(feature = "window")] +unsafe impl Send for Window {} +#[cfg(feature = "window")] +unsafe impl Sync for Window {} + #[cfg(feature = "window")] #[deriving(Clone)] pub struct WindowProxy; diff --git a/src/win32/init.rs b/src/win32/init.rs index 3cdf8d5a..7b236b0e 100644 --- a/src/win32/init.rs +++ b/src/win32/init.rs @@ -18,11 +18,15 @@ use winapi; /// receive an event for another window. thread_local!(static WINDOW: Rc)>>> = Rc::new(RefCell::new(None))); +/// Work-around the fact that HGLRC doesn't implement Send +pub struct ContextHack(pub winapi::HGLRC); +unsafe impl Send for ContextHack {} + pub fn new_window(builder_dimensions: Option<(uint, uint)>, builder_title: String, builder_monitor: Option, builder_gl_version: Option<(uint, uint)>, builder_debug: bool, builder_vsync: bool, builder_hidden: bool, - builder_sharelists: Option, builder_multisampling: Option) + builder_sharelists: Option, builder_multisampling: Option) -> Result { use std::mem; @@ -38,6 +42,8 @@ pub fn new_window(builder_dimensions: Option<(uint, uint)>, builder_title: Strin // so we create a new thread dedicated to this window. // This is the only safe method. Using `nosend` wouldn't work for non-native runtime. ::std::thread::Thread::spawn(move || { + let builder_sharelists = builder_sharelists.map(|s| s.0); + // registering the window class let class_name = { let class_name: Vec = "Window Class".utf16_units().chain(Some(0).into_iter()) diff --git a/src/win32/mod.rs b/src/win32/mod.rs index dba08e56..a5f05476 100644 --- a/src/win32/mod.rs +++ b/src/win32/mod.rs @@ -51,6 +51,11 @@ impl HeadlessContext { } } +#[cfg(feature = "headless")] +unsafe impl Send for HeadlessContext {} +#[cfg(feature = "headless")] +unsafe impl Sync for HeadlessContext {} + /// The Win32 implementation of the main `Window` object. pub struct Window { /// Main handle for the window. @@ -75,6 +80,9 @@ pub struct Window { is_closed: AtomicBool, } +unsafe impl Send for Window {} +unsafe impl Sync for Window {} + #[cfg(feature = "window")] impl Window { /// See the docs in the crate root file. @@ -82,7 +90,8 @@ impl Window { let WindowBuilder { dimensions, title, monitor, gl_version, gl_debug, vsync, visible, sharing, multisampling } = builder; init::new_window(dimensions, title, monitor, gl_version, gl_debug, vsync, - !visible, sharing.map(|w| w.window.context), multisampling) + !visible, sharing.map(|w| init::ContextHack(w.window.context)), + multisampling) } } diff --git a/src/x11/headless.rs b/src/x11/headless.rs index 95f52333..d6f1023c 100644 --- a/src/x11/headless.rs +++ b/src/x11/headless.rs @@ -62,3 +62,6 @@ impl Drop for HeadlessContext { unsafe { ffi::OSMesaDestroyContext(self.context) } } } + +unsafe impl Send for HeadlessContext {} +unsafe impl Sync for HeadlessContext {} diff --git a/src/x11/window/mod.rs b/src/x11/window/mod.rs index 422b5b66..0a8c3d58 100644 --- a/src/x11/window/mod.rs +++ b/src/x11/window/mod.rs @@ -34,6 +34,9 @@ struct XWindow { im: ffi::XIM, } +unsafe impl Send for Window {} +unsafe impl Sync for Window {} + impl Drop for XWindow { fn drop(&mut self) { unsafe {