Split mgba log if too big (#646)

- [x] Changelog updated

CHANGELOG.md

@@ -28,6 +28,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixnums are now implemented with `num_traits` trait definitions.
 - Rather than having our own sync with Statics, use the standard portable
   atomics crate. These are reexported for convenience.
+- `Mgba` no longer implements `Write`. You're unlikely to notice as
+  `agb::println!` is unchanged.
+- Writes of long messages to mgba are split over multiple log messages if they
+  overflow mgba's buffer. On a panic, only the final message will be Fatal with
+  the preceding ones (if needed) being Info.
 
 ## [0.19.1] - 2024/03/06
 

agb/src/mgba.rs

@@ -32,15 +32,13 @@ pub(crate) fn test_runner_measure_cycles() {
     NUMBER_OF_CYCLES.set(0);
 }
 
-pub struct Mgba {
+pub struct Mgba {}
-    bytes_written: usize,
-}
 
 impl Mgba {
     #[must_use]
     pub fn new() -> Option<Self> {
         if is_running_in_mgba() {
-            Some(Mgba { bytes_written: 0 })
+            Some(Mgba {})
         } else {
             None
         }
@@ -51,31 +49,33 @@ impl Mgba {
         output: core::fmt::Arguments,
         level: DebugLevel,
     ) -> Result<(), core::fmt::Error> {
-        write!(self, "{output}")?;
+        let mut writer = MgbaWriter { bytes_written: 0 };
+        write!(&mut writer, "{output}")?;
         self.set_level(level);
         Ok(())
     }
 }
 
+struct MgbaWriter {
+    bytes_written: usize,
+}
+
 impl Mgba {
     pub fn set_level(&mut self, level: DebugLevel) {
         DEBUG_LEVEL.set(DEBUG_FLAG_CODE | level as u16);
-        self.bytes_written = 0;
     }
 }
 
-impl core::fmt::Write for Mgba {
+impl core::fmt::Write for MgbaWriter {
     fn write_str(&mut self, s: &str) -> Result<(), core::fmt::Error> {
-        let mut str_iter = s.bytes();
+        for b in s.bytes() {
-        while self.bytes_written < 255 {
+            if self.bytes_written > 255 {
-            match str_iter.next() {
+                DEBUG_LEVEL.set(DEBUG_FLAG_CODE | DebugLevel::Info as u16);
-                Some(byte) => {
+                self.bytes_written = 0;
-                    OUTPUT_STRING.set(self.bytes_written, byte);
+            }
+            OUTPUT_STRING.set(self.bytes_written, b);
             self.bytes_written += 1;
         }
-                None => return Ok(()),
-            }
-        }
         Ok(())
     }
 }