alex/nih-plug
1
0
Fork 0
Code Activity

Remove todos about fixing skewed discrete ranges

Browse source 
Because those have been removed.
This commit is contained in:
Robbert van der Helm 2022-03-08 00:27:25 +01:00
parent 8ee380864c
commit 10ced981bd
2 changed files with 0 additions and 4 deletions
src/wrapper
clap
wrapper.rs
vst3
wrapper.rs

2
src/wrapper/clap/wrapper.rs
View file

@ -1438,7 +1438,6 @@ impl<P: ClapPlugin> Wrapper<P> {
// Stepped parameters are unnormalized float parameters since there's no separate step // Stepped parameters are unnormalized float parameters since there's no separate step
// range option // range option
// TODO: This should probably be encapsulated in some way so we don't forget about this in one place // TODO: This should probably be encapsulated in some way so we don't forget about this in one place
// TODO: Like with VST3, this won't actually do the correct thing with skewed stepped parameters
param_info.max_value = step_count.unwrap_or(1) as f64; param_info.max_value = step_count.unwrap_or(1) as f64;
param_info.default_value = *default_value as f64 * step_count.unwrap_or(1) as f64; param_info.default_value = *default_value as f64 * step_count.unwrap_or(1) as f64;
} }
@ -1462,7 +1461,6 @@ impl<P: ClapPlugin> Wrapper<P> {
}; };
true true
} else if let Some(param_ptr) = wrapper.param_by_hash.get(&param_id) { } else if let Some(param_ptr) = wrapper.param_by_hash.get(&param_id) {
// TODO: As explained above, this may do strange things with skewed discrete parameters
*value = *value =
param_ptr.normalized_value() as f64 * param_ptr.step_count().unwrap_or(1) as f64; param_ptr.normalized_value() as f64 * param_ptr.step_count().unwrap_or(1) as f64;
true true

2
src/wrapper/vst3/wrapper.rs
View file

@ -337,8 +337,6 @@ impl<P: Vst3Plugin> IEditController for Wrapper<P> {
u16strlcpy(&mut info.title, param_ptr.name()); u16strlcpy(&mut info.title, param_ptr.name());
u16strlcpy(&mut info.short_title, param_ptr.name()); u16strlcpy(&mut info.short_title, param_ptr.name());
u16strlcpy(&mut info.units, param_ptr.unit()); u16strlcpy(&mut info.units, param_ptr.unit());
// TODO: The host assumes these steps are distributed linearly, so this may cause weird
// behavior with skewed integers
info.step_count = param_ptr.step_count().unwrap_or(0) as i32; info.step_count = param_ptr.step_count().unwrap_or(0) as i32;
info.default_normalized_value = *default_value as f64; info.default_normalized_value = *default_value as f64;
info.unit_id = vst3_sys::vst::kRootUnitId; info.unit_id = vst3_sys::vst::kRootUnitId;