alex/nih-plug
1
0
Fork 0
Code Activity

Scrap the relative gain reduction idea

Browse source 
This looks super confusing.
This commit is contained in:
Robbert van der Helm 2023-03-21 23:51:10 +01:00
parent 1c8546ae13
commit 14cd737e8f
2 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
plugins/spectral_compressor/CHANGELOG.md
View file

@ -12,8 +12,7 @@ Versioning](https://semver.org/spec/v2.0.0.html).
- Added a basic analyzer that visualizes the target curve, the spectral envelope - Added a basic analyzer that visualizes the target curve, the spectral envelope
followers and gain reduction. The current version will be expanded a bit in followers and gain reduction. The current version will be expanded a bit in
the future to show this information relative to the threshold target curve, the future with some tooltips and labels to show more information.
with some tooltips for more information.
### Changed ### Changed

1
plugins/spectral_compressor/src/editor/analyzer.rs
View file

@ -351,7 +351,6 @@ fn draw_gain_reduction(
// the way to the bottom of the spectrum analyzer. 40 dB of additional gain causes // the way to the bottom of the spectrum analyzer. 40 dB of additional gain causes
// the bar to be drawn from the center all the way to the top of the graph. // the bar to be drawn from the center all the way to the top of the graph.
// NOTE: Y-coordinates go from top to bottom, hence the minus // NOTE: Y-coordinates go from top to bottom, hence the minus
// TODO: The y-position should be relative to the target curve
let t_y = ((-gain_difference_db + 40.0) / 80.0).clamp(0.0, 1.0); let t_y = ((-gain_difference_db + 40.0) / 80.0).clamp(0.0, 1.0);
path.move_to(bounds.x + (bounds.w * t_start), bounds.y + (bounds.h * 0.5)); path.move_to(bounds.x + (bounds.w * t_start), bounds.y + (bounds.h * 0.5));