Move the TODO on GUI opening xruns
This commit is contained in:
parent
3bd3696abe
commit
3ede5ed751
2 changed files with 4 additions and 1 deletions
|
@ -35,7 +35,6 @@ pub use egui;
|
|||
/// your plugin' [nih_plug::Plugin::editor_size()] implementation.
|
||||
//
|
||||
// TODO: DPI scaling, this needs to be implemented on the framework level
|
||||
// TODO: Opening the GUI causes an xrun, why?
|
||||
pub fn create_egui_editor<T, U>(
|
||||
parent: EditorWindowHandle,
|
||||
size: Arc<AtomicCell<(u32, u32)>>,
|
||||
|
|
|
@ -1364,6 +1364,10 @@ impl<P: Plugin> IPlugView for WrapperView<P> {
|
|||
}
|
||||
};
|
||||
|
||||
// FIXME: On second thought, this needs some reworking. Needing a read lock on the
|
||||
// plugin's object means that the process call (which requires a write lock) will
|
||||
// be blocked. The better API will be to move the create function to the `Editor`
|
||||
// struct, so we can already fetch that during initialization.
|
||||
*editor = self
|
||||
.inner
|
||||
.plugin
|
||||
|
|
Loading…
Add table
Reference in a new issue