alex/nih-plug
1
0
Fork 0
Code Activity

Add a fixme for REAPER's broken bypass handling

Browse source
This commit is contained in:
Robbert van der Helm 2022-04-27 16:45:34 +02:00
parent 3d8f7afd22
commit afde489bbf
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/wrapper/vst3/context.rs
View file

@ -64,6 +64,9 @@ impl<P: Vst3Plugin> GuiContext for WrapperGuiContext<P> {
// the plugin is currently processing audio, the host will pass this change back // the plugin is currently processing audio, the host will pass this change back
// to the plugin in the audio callback. This also prevents the values from // to the plugin in the audio callback. This also prevents the values from
// changing in the middle of the process callback, which would be unsound. // changing in the middle of the process callback, which would be unsound.
// FIXME: So this doesn't work for REAPER, because they just silently stop
// processing audio when you bypass the plugin. Great. We can add a time
// based heuristic to work aorund this in the meantime.
if !self.inner.is_processing.load(Ordering::SeqCst) { if !self.inner.is_processing.load(Ordering::SeqCst) {
self.inner.set_normalized_value_by_hash( self.inner.set_normalized_value_by_hash(
*hash, *hash,