alex/nih-plug
1
0
Fork 0
Code Activity

Add todos about potential duplicate reset calls

Browse source
This commit is contained in:
Robbert van der Helm 2022-04-26 14:15:57 +02:00
parent 4779991edf
commit dedbfebb71
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/wrapper/clap/wrapper.rs
View file

@ -2620,6 +2620,9 @@ impl<P: ClapPlugin> Wrapper<P> {
&buffer_config, &buffer_config,
&mut wrapper.make_process_context(Transport::new(buffer_config.sample_rate)), &mut wrapper.make_process_context(Transport::new(buffer_config.sample_rate)),
); );
// TODO: This also goes for the VST3 version, but should we call reset here? Won't the
// host always restart playback? Check this with a couple of hosts and remove the
// duplicate reset if it's not needed.
process_wrapper(|| plugin.reset()); process_wrapper(|| plugin.reset());
} }

3
src/wrapper/vst3/wrapper.rs
View file

@ -298,6 +298,9 @@ impl<P: Vst3Plugin> IComponent for Wrapper<P> {
.inner .inner
.make_process_context(Transport::new(buffer_config.sample_rate)), .make_process_context(Transport::new(buffer_config.sample_rate)),
); );
// TODO: This also goes for the CLAP version, but should we call reset here? Won't the
// host always restart playback? Check this with a couple of hosts and remove the
// duplicate reset if it's not needed.
process_wrapper(|| plugin.reset()); process_wrapper(|| plugin.reset());
} }