alex/nih-plug
1
0
Fork 0
Code Activity
1083 commits 1 branch 0 tags 4.3 MiB
Commit graph

111 commits

Author SHA1 Message Date
Robbert van der Helm f05e31d9e3 Sort additional VST3 interace implementations 
The sensible order would be IComponent, IEditController,
IAudioProcessor, and then everything else.
 2022-05-07 13:18:20 +02:00
Robbert van der Helm 7cb671319e Properly define all predefined note expressions 
This is apparently how you're supposed to do it in VST3. How would you
know? You'd ask Steinberg.
 2022-05-05 15:35:14 +02:00
Robbert van der Helm 3d454bfc9c Don't process audio at all with invalid buffers 
If the host does some kind of flush this way with num_samples > 0 but
without any outputs or with zero output channels then we should not try
to read from the now invalid pointers from the previous cycle.
 2022-04-30 02:00:09 +02:00
Robbert van der Helm ddc28eef5e Clarify the VST3 output .take(num_outputs) 2022-04-30 01:52:53 +02:00
Robbert van der Helm 4fb67a720b Add a todo for fallback DPI scale detection 2022-04-27 19:26:39 +02:00
Robbert van der Helm 21e28fdca2 Handle hosts providing zero output channels 2022-04-27 16:52:30 +02:00
Robbert van der Helm afde489bbf Add a fixme for REAPER's broken bypass handling 2022-04-27 16:45:34 +02:00
Robbert van der Helm dedbfebb71 Add todos about potential duplicate reset calls 2022-04-26 14:15:57 +02:00
Robbert van der Helm 582ab50e58 Move VST3 Plugin::reset() call to set_processing() 
This lets the host reset buffers the intended way.
 2022-04-26 13:42:32 +02:00
Robbert van der Helm 566095802c Decouple state functions from CLAP/VST3 wrapper 
This should also be usable with a plain `params` object, since we don't
need hashes in the standalone wrapper.
 2022-04-24 19:46:07 +02:00
Robbert van der Helm 9acd312768 Parmaeters are not real, they can't hurt you 2022-04-24 19:46:07 +02:00
Robbert van der Helm f838062d72 Don't use an Arc for the CLAP editor 2022-04-24 15:48:05 +02:00
Robbert van der Helm f895a27136 Simplify known VST3 note expression match 2022-04-24 15:31:02 +02:00
Robbert van der Helm a79099f573 Work around Bitwig VST3 note expressions bug 
Bitwig will only send these note expression events if the plugin claims
to support at least one custom note expression type, and if it returns
`kResultOk` on `INoteExpressionController::get_note_expression_info()`
when the expression ID is equal to the note expression type (even though
these are out of range, since this index argument is supposed to be a
linear index from `0..count`).
 2022-04-23 15:00:30 +02:00
Robbert van der Helm 3361c4454b Define constants for VST3 note expression types 2022-04-23 14:49:19 +02:00
Robbert van der Helm b88707769a Add a way to find out the current plugin API 2022-04-21 21:27:36 +02:00
Robbert van der Helm 2bc77ed691 Work around vst3-sys not allowing #[cfg()] fields 2022-04-20 20:44:07 +02:00
Robbert van der Helm 6ae05eb01b Log assertion failure if a VST3 resize is denied 2022-04-20 20:35:44 +02:00
Robbert van der Helm 8966ca5280 Fix C++ interface pointer transmutes 
These are supposed to be pointers to vtable pointers.
 2022-04-20 20:25:59 +02:00
Robbert van der Helm 5d343f7873 Also perform resize requests using the run loop 2022-04-20 19:52:02 +02:00
Robbert van der Helm 98924a5728 Use the host's run loop to handle VST3 tasks 2022-04-20 19:51:26 +02:00
Robbert van der Helm 37b62e4278 Add an IRunLoop event runner on Linux 2022-04-20 19:44:03 +02:00
Robbert van der Helm 4fa54ceabe Add an object for implementing IEventLoop 
We can't do this directly on WrapperView because of vst3-sys
limitations.
 2022-04-20 17:18:41 +02:00
Robbert van der Helm f3bb552cfe Get a reference to the host's IRunLoop 2022-04-20 17:03:15 +02:00
Robbert van der Helm 0fd9a68146 Move u16strlcpy to the VST3 wrapper utils module 2022-04-15 16:13:14 +02:00
Robbert van der Helm 5e486ab3d9 Explicitly handle 0 channel IO 
Instead of treating it as a flush. This is needed for note effect
plugins.
 2022-04-11 20:46:51 +02:00
Robbert van der Helm 65d87f87ed Add a way to output note events 
This supports all note events supported by NIH-plug, and both CLAP and
VST3.
 2022-04-11 20:46:51 +02:00
Robbert van der Helm e4606918e7 Rename next_midi_event() to next_event() 2022-04-11 18:15:14 +02:00
Robbert van der Helm 5b5bbf19f7 Prefix all polyphonic expressions with Poly 
Makes it much more obvious that they're polyphonic at a glance.
 2022-04-11 15:57:27 +02:00
Robbert van der Helm 476dfb9f81 Fix compilation failure from f0303fe 2022-04-09 12:12:34 +02:00
Robbert van der Helm 33c2d8288b Don't warn on parameter hash overflow 
But do mention overflows in the duplicate parameter warning.
 2022-04-09 11:47:23 +02:00
Robbert van der Helm f0303fed4b Remove now unnecessary input events sort 
This was added in anticipation of having to merge the parameter change
MIDI CC events into the events stream, but VST3 threw a curveball and
now we need to do the sorting one step earlier.
 2022-04-09 11:32:20 +02:00
Robbert van der Helm 52d7b47a24 Improve block splitting transport information 
Don't do any recomputations at the start of the buffer, and also
recompute the bar positions and numbers.
 2022-04-08 23:10:38 +02:00
Robbert van der Helm 1a8f81e4c0 Support MIDI CCs, aftertouch, pitch bend for VST3 
This required rewriting the way events and parameter changes are handled
for VST3 by putting them all in a single sorted array, because we can
now no longer read directly from the host's events list because we also
need to mix these new generated MIDI CC events in with it.
 2022-04-08 20:53:32 +02:00
Robbert van der Helm 059c733b78 Handle predefined VST3 note expressions 2022-04-08 17:49:13 +02:00
Robbert van der Helm 9740246d0a Always sort VST3 note events in prep for CCs 
So we won't forget to add this then. CC messages come from the parameter
change queues while regular note event messages come from another queue,
so they need to be merged into one sorted queue.
 2022-04-07 23:57:56 +02:00
Robbert van der Helm 24837d1552 Implement full MIDI support for CLAP 2022-04-07 23:28:31 +02:00
Robbert van der Helm 0b3a5cd297 Support all of the CLAP expression types 
These aren't supported for VST3 yet, we'll need to register note
expression controllers for that.
 2022-04-07 21:17:31 +02:00
Robbert van der Helm b9a10455bb Add polyphonic aftertouch support 2022-04-07 20:55:31 +02:00
Robbert van der Helm 1141616466 Replace ACCEPTS_MIDI bool with new enum 
So we can gate future MIDI CC support behind an additional option since
this involves more work on the VST3 side.
 2022-04-07 20:27:37 +02:00
Robbert van der Helm 8f359feadb Store velocity as a float 
Instead of converting this to a 0-127 value. We may be throwing away
precision otherwise.
 2022-04-07 20:12:30 +02:00
Robbert van der Helm 2af3f84416 Rename State to PluginState 
Now that it is part of the public API.
 2022-04-07 17:39:34 +02:00
Robbert van der Helm 84bac0a47c Spool param rescan call to the GUI thread 
Otherwise the CLAP example host std::terminates, and we can also reuse
the existing restart task for the VST3 wrapper.
 2022-04-07 17:25:12 +02:00
Robbert van der Helm d0064f87d6 Add state saving and restoring through GuiContext 
While preventing any possible data races.
 2022-04-07 17:19:24 +02:00
Robbert van der Helm 083885a40c Rework Params trait API with Arc instead of Pin 
This is a breaking change requiring a small change to plugin
implementations.

The reason why `Pin<&dyn Params>` was used was more as a hint to
indicate that the object must last for the plugin's lifetime, but `Pin`
doesn't enforce that. It also makes the APIs a lot more awkward.
Requiring the use of `Arc` fixes the following problems:

- When storing the params object in the wrapper, the `ParamPtr`s are
  guaranteed to be stable.
- This makes it possible to access the `Params` object without acquiring
  a lock on the plugin, this is very important for implementing
  plugin-side preset management.
- It enforces immutability on the `Params` object.
- And of course the API is much nicer without a bunch of unsafe code to
  work around Pin's limitations.
 2022-04-07 15:31:46 +02:00
Robbert van der Helm b1c34146ee Get rid of automatically generated bypass params 
I thought these were mandatory in VST3, they are not.
 2022-04-06 13:34:32 +02:00
Robbert van der Helm f301726f37 Fix sample accurate automation for VST3 2022-03-29 00:56:04 +02:00
Robbert van der Helm f9db59f4bc Add a resize request callback to VST3 GuiContext 
With some more work in baseview this can be used to resize windows from
the plugin.
 2022-03-27 19:23:43 +02:00
Robbert van der Helm 8d71369b2e Rename .is_bypass() to .make_bypass() 
Because just like `.bypass()` sounds like a getter, so does
`.is_bypass()`.
 2022-03-27 03:45:06 +02:00
Robbert van der Helm 8090d0ae41 Add explicit bypass parameter handling 
Plugins can mark a `BoolParam` with `.is_bypass()`. Hosts can then link
use that parameter directly in their own UI.
 2022-03-23 17:42:48 +01:00