alex/rp-hal-boards
1
0
Fork 0
mirror of https://github.com/italicsjenga/rp-hal-boards.git synced 2024-12-24 13:11:30 +11:00
Code Issues Packages Projects Releases Wiki Activity
773 commits 1 branch 0 tags 1.4 MiB
Commit graph

11 commits

Author SHA1 Message Date
Nathan Marley 8b7c67ee47 Remove redundant variable in pico uart examples 
This removes the hard-coded XTAL_FREQ_HZ variable from the rp-pico UART
examples as it's already defined in this library as XOSC_CRYSTAL_FREQ.

I noticed this as I was looking thru the examples and it seems like most of
them use the rp_pico::XOSC_CRYSTAL_FREQ value instead. I'm new to embedded so
please let me know if I got something wrong here. Thanks!
 2023-05-01 11:33:34 -03:00
Jan Niehusmann b81ad6f599 Use UartConfig::new constructor instead of common_configs in examples 2022-10-15 17:14:43 +00:00
Wilfried Chauveau 93ec18be07 migrate rp2040-hal from embedded_time to fugit 2022-08-24 22:46:34 +01:00
Wilfried Chauveau 51db37a4cb
replace cortex_m::interrupt::Mutex with critical_section::Mutex in examples (#422) 2022-08-21 19:00:57 +01:00
Jan Niehusmann f8984a9eac Implement conversion from Clock to Hertz using reference 
Implementing `impl From<SystemClock> for Hertz` is a footgun, as
SystemClock is not Copy, so the automatic conversion consumes the
owned clock.

This is visible in the example i2c.rs:

```
    let mut i2c = hal::I2C::i2c1(
        pac.I2C1,
        sda_pin,
        scl_pin, // Try `not_an_scl_pin` here
        400.kHz(),
        &mut pac.RESETS,
        clocks.peripheral_clock,
    );
```

If the user wants to use both `i2c0` and `i2c1` at the same time,
copying from this example won't work:

```
error[E0382]: use of moved value: `clocks.peripheral_clock`
   --> rp2040-hal/examples/i2c.rs:106:9
    |
97  |         clocks.peripheral_clock,
    |         ----------------------- value moved here
...
106 |         clocks.peripheral_clock,
    |         ^^^^^^^^^^^^^^^^^^^^^^^ value used here after move
    |
    = note: move occurs because `clocks.peripheral_clock` has type
`PeripheralClock`, which does not implement the `Copy` trait
```

As getting the frequency from a clock doesn't really need ownership,
changing it to `impl From<&SystemClock> for Hertz` is both more
logical and provides better usability.

This is, however, a breaking change: Code relying on this trait
implementation needs to be changed by adding a `&`.
 2022-07-22 20:17:26 +00:00
9names 895bae90b5
Merge pull request #324 from 9names/bsp_use_hal_entry_macro 
Add reexport of rp2040::entry to BSPs
 2022-05-31 23:41:45 +10:00
mqy 623457a498 fixed typos 2022-04-30 12:51:45 +10:00
9names 12cbab967c Update all BSP examples to use the BSP's re-exported entry macro 2022-04-10 21:54:56 +10:00
9names 0e1fe81384 Remove static BOOT2 decl in BSP examples so they build 2022-01-03 23:07:03 +11:00
Jonathan Pallant 7da16a726f Fixing typos spotted in the review. 2021-12-26 19:39:16 +00:00
Jonathan Pallant (Ferrous Systems) d3bd232885 Added two UART IRQ examples. 
They are in the pico BSP as they need the 'rt' feature. Also includes
changes to the UART driver for enabling/disabling interrupts.
 2021-12-26 19:33:23 +00:00