Merge pull request #72 from tomaka/vsync

Add `with_vsync` to WindowBuilder, plus the win32 implementation
This commit is contained in:
tomaka 2014-10-27 09:24:31 +01:00
commit a6bc0b0ba0
4 changed files with 26 additions and 5 deletions

View file

@ -73,6 +73,7 @@ pub struct WindowBuilder {
title: String, title: String,
monitor: Option<winimpl::MonitorID>, monitor: Option<winimpl::MonitorID>,
gl_version: Option<(uint, uint)>, gl_version: Option<(uint, uint)>,
vsync: bool,
} }
#[cfg(feature = "window")] #[cfg(feature = "window")]
@ -84,6 +85,7 @@ impl WindowBuilder {
title: "gl-init-rs window".to_string(), title: "gl-init-rs window".to_string(),
monitor: None, monitor: None,
gl_version: None, gl_version: None,
vsync: false,
} }
} }
@ -119,6 +121,12 @@ impl WindowBuilder {
self self
} }
/// Requests that the window has vsync enabled.
pub fn with_vsync(mut self) -> WindowBuilder {
self.vsync = true;
self
}
/// Builds the window. /// Builds the window.
/// ///
/// Error should be very rare and only occur in case of permission denied, incompatible system, /// Error should be very rare and only occur in case of permission denied, incompatible system,
@ -339,6 +347,10 @@ impl Window {
/// ///
/// You should call this function every time you have finished rendering, or the image /// You should call this function every time you have finished rendering, or the image
/// may not be displayed on the screen. /// may not be displayed on the screen.
///
/// **Warning**: if you enabled vsync, this function will block until the next time the screen
/// is refreshed. However drivers can choose to override your vsync settings, which means that
/// you can't know in advance whether `swap_buffers` will block or not.
#[inline] #[inline]
pub fn swap_buffers(&self) { pub fn swap_buffers(&self) {
self.window.swap_buffers() self.window.swap_buffers()

View file

@ -23,7 +23,8 @@ pub mod wgl_extra {
version: "1.0", version: "1.0",
generator: "struct", generator: "struct",
extensions: [ extensions: [
"WGL_ARB_create_context" "WGL_ARB_create_context",
"WGL_EXT_swap_control"
] ]
} }
} }

View file

@ -16,7 +16,7 @@ local_data_key!(WINDOW: (ffi::HWND, Sender<Event>))
pub fn new_window(builder_dimensions: Option<(uint, uint)>, builder_title: String, pub fn new_window(builder_dimensions: Option<(uint, uint)>, builder_title: String,
builder_monitor: Option<super::MonitorID>, builder_monitor: Option<super::MonitorID>,
builder_gl_version: Option<(uint, uint)>, builder_gl_version: Option<(uint, uint)>, builder_vsync: bool,
builder_headless: bool) -> Result<Window, String> builder_headless: bool) -> Result<Window, String>
{ {
use std::mem; use std::mem;
@ -346,6 +346,14 @@ pub fn new_window(builder_dimensions: Option<(uint, uint)>, builder_title: Strin
lib lib
}; };
// handling vsync
if builder_vsync {
if extra_functions.SwapIntervalEXT.is_loaded() {
unsafe { ffi::wgl::MakeCurrent(hdc, context) };
extra_functions.SwapIntervalEXT(1);
}
}
// building the struct // building the struct
let window = Window{ let window = Window{
window: real_window, window: real_window,

View file

@ -25,7 +25,7 @@ impl HeadlessContext {
/// See the docs in the crate root file. /// See the docs in the crate root file.
pub fn new(builder: HeadlessRendererBuilder) -> Result<HeadlessContext, String> { pub fn new(builder: HeadlessRendererBuilder) -> Result<HeadlessContext, String> {
let HeadlessRendererBuilder { dimensions, gl_version } = builder; let HeadlessRendererBuilder { dimensions, gl_version } = builder;
init::new_window(Some(dimensions), "".to_string(), None, gl_version, true) init::new_window(Some(dimensions), "".to_string(), None, gl_version, false, true)
.map(|w| HeadlessContext(w)) .map(|w| HeadlessContext(w))
} }
@ -68,8 +68,8 @@ pub struct Window {
impl Window { impl Window {
/// See the docs in the crate root file. /// See the docs in the crate root file.
pub fn new(builder: WindowBuilder) -> Result<Window, String> { pub fn new(builder: WindowBuilder) -> Result<Window, String> {
let WindowBuilder { dimensions, title, monitor, gl_version } = builder; let WindowBuilder { dimensions, title, monitor, gl_version, vsync } = builder;
init::new_window(dimensions, title, monitor, gl_version, false) init::new_window(dimensions, title, monitor, gl_version, vsync, false)
} }
} }