Michael Streif
5bf303fd26
Improve handling of file paths in the windows DnD handler ( #980 )
...
* Make FileDropHandler::iterate_filenames more robust
by replacing the call to mem::uninitialized with mem::zeroed and change
file name retrieval to use buffers of exact length as reported
by DragQueryFileW instead of relying on MAX_PATH.
* Change remaining calls of uninitialized to zeroed
* Run rustfmt
* Add CHANGELOG entry and comment
2019-06-28 18:07:36 -04:00
Victor Berger
b8192ef6f6
Revert "wayland: use an invisible surface as shell surface ( #835 )" ( #981 )
...
This reverts commit 65587ef43a
2019-06-28 15:31:54 -04:00
Ho-Yon Mak
23354cf1a5
Implement _NET_WM_PING for X11 ( #977 )
2019-06-27 18:40:27 -06:00
Tristam MacDonald
ac08601b40
Implement DeviceEvent::Button on Mac ( #967 )
...
* Add deviceevent logging to cursor_grab example
* Implement DeviceEvent::Button on Mac
2019-06-27 02:58:21 -04:00
chichid
0e20973bdb
Fix 968: Invisible windows steal focus from visible windows Win32 ( #968 )
2019-06-26 00:04:49 -04:00
Murarth
29e2481597
Remove XFlush call in event loop ( #982 )
...
Internally, `XFlush` calls `_XSend` to write data. It then calls
`XEventsQueued(display, QueuedAfterReading)`, which reads data from the
X server connection. This prevents the event loop source callback from
being run, as there is no longer data waiting on the socket.
Ideally, we would want to call `_XSend` directly to ensure that no
output is buffered by Xlib. However, this function is not exported as
part of Xlib's public API.
Testing with the `XFlush` call removed does not appear to adversely
affect the performance of an application. If any bugs should eventually
arise from this change, perhaps another function may be used in place of
`XFlush`, such as `XPending`, which writes buffered output but does not
so aggressively read from the X server connection.
Closes #865
2019-06-25 15:29:52 -06:00
Cherser-s
3555de114a
Wayland: Add relative pointer movement ( #973 )
...
* Add relative pointer movement for Wayland
* Format changed code with rustfmt
* Wayland: merge window and device event queues into one
* Replace map_or_else call for simplification
2019-06-25 03:00:41 -06:00
Osspial
a195ce8146
Re-format on stable rustfmt ( #974 )
2019-06-24 12:14:55 -04:00
Abendstolz
2467a997f4
[ #963 ] Change XRandR display size check to also take height into account ( #964 )
2019-06-22 18:48:51 +02:00
Felix Rabe
f457c6a0b8
Change Suspended(true/false) => Suspended/Resumed ( #959 )
2019-06-21 20:59:31 -06:00
Osspial
e2c84725de
Format everything and add rustfmt to travis ( #951 )
...
* Format everything and add rustfmt to travis
* Remove extern crate winit from examples and add force_multiline_blocks
* Format the code properly
* Fix inconsistent period in PULL_REQUEST_TEMPLATE.md
* Only run rustfmt on nightly
* Travis fixings
2019-06-21 11:33:15 -04:00
Osspial
b1b5aefc4b
Implement fix described in #851 ( #945 )
...
* Implement fix described in #851
* Add changelog entry
2019-06-20 23:59:27 -04:00
Felix Rabe
c56a66cb90
Fix warnings ( #929 )
...
* Fix warnings
* Bring back derivatives crate for Windows
2019-06-19 15:12:01 -04:00
Aleksi Juvani
c35fdc8d61
Fix thread-safety of set_maximized and set_title on macOS ( #922 )
2019-06-18 00:34:27 -06:00
CrLF0710
f879bca21c
Migrate to 2018 edition. ( #924 )
...
* Migrate to 2018 edition.
* Use impl Iterator at one site.
* Fix more rust 2018 idioms.
2019-06-17 14:27:00 -04:00
Victor Berger
9a11f90a02
x11/wayland: Don't reset control flow between loop ticks ( #916 )
2019-06-13 12:52:10 -04:00
Victor Berger
65587ef43a
wayland: use an invisible surface as shell surface ( #835 )
...
This decorelates the window management from the actual user content,
meaning:
- the created window no longer needs the user to draw something to
start existing
- it reduces our need to do roundtrips during initialization to
avoid protocol errors
2019-06-13 12:50:02 -04:00
Osspial
ea5c21950c
Change Monitor dimensions functions to size functions ( #911 )
2019-06-13 00:33:44 -06:00
Aleksi Juvani
47b5dfa034
Support listing available video modes for a monitor ( #896 )
...
* Support listing available video modes for a monitor
* Use derivative for Windows `MonitorHandle`
* Update FEATURES.md
* Fix multiline if statement
* Add documentation for `VideoMode` type
2019-06-12 14:07:25 -04:00
Nikolai Vazquez
f256ff7d58
Make ns identifiers use snake_case on macOS ( #904 )
...
This makes the macOS API style consistent with that of iOS.
2019-06-10 19:09:38 -04:00
Osspial
0eefa3ba42
Fix compiler warning of potential undefined behavior ( #892 )
2019-05-30 20:42:53 -04:00
aloucks
08f8f89702
Fix control flow issues with Window::request_redraw (eventloop-2.0) ( #890 )
...
* Fix request_redraw with Poll and WaitUntil(time_in_the_past) on Windows
`Window::request_redraw` now fires a `RedrawRequested` event when
called from an `Event::EventsCleared` callback while the control
flow is set to `Poll`. A control flow of `WaitUntil(resume_time)`,
will now also fire the `RedrawRequested` event when `resume_time`
is in the past.
* Prevent panic on x11 when WaitUntil(resume_time) is in the past
* Prevent panic on wayland when WaitUntil(resume_time) is in the past
2019-05-29 22:33:52 -06:00
Osspial
0df436901a
Refine function names and type signatures ( #886 )
...
* First name consistency pass. More to come!
* Remove multitouch variable (hopefully this compiles!)
* Remove CreationError::NotSupported
* Add new error handling types
* Remove `get_` prefix from getters.
This is as per the Rust naming conventions recommended in
https://rust-lang-nursery.github.io/api-guidelines/naming.html#getter-names-follow-rust-convention-c-getter
* Make changes to Window position and size function signatures
* Remove CreationError in favor of OsError
* Begin updating iOS backend
* Change MonitorHandle::outer_position to just position
* Fix build on Windows and Linux
* Add Display and Error implementations to Error types
* Attempt to fix iOS build.
I can't actually check that this works since I can't cross-compile to
iOS on a Windows machine (thanks apple :/) but this should be one of
several commits to get it working.
* Attempt to fix iOS errors, and muck up Travis to make debugging easier
* More iOS fixins
* Add Debug and Display impls to OsError
* Fix Display impl
* Fix unused code warnings and travis
* Rename set_ime_spot to set_ime_position
* Add CHANGELOG entry
* Rename set_cursor to set_cursor_icon and MouseCursor to CursorIcon
* Organize Window functions into multiple, categorized impls
* Improve clarity of function ordering and docs in EventLoop
2019-05-29 21:29:54 -04:00
Osspial
76660f3621
Fix Windows backend invoking unreachable! with Exit and run_return ( #887 )
2019-05-27 13:45:26 -04:00
mtak-
3a7350cbb9
El2.0 ios ( #871 )
...
* port ios winit el2.0 implementation to the new rust-windowing repo
* unimplemented! => unreachable
trailing comma in CFRunLoopTimerCallback
* implement get_fullscreen
* add iOS specific platform documentation. Add a TODO about how to possibly extend the iOS backend to work have methods callable from more than just the main thread
* assert that window is only dropped from the main thread
* assert_main_thread called from fewer places
2019-05-25 21:10:41 -04:00
Lucas Kent
93502e0cda
Fix warning ( #880 )
2019-05-24 05:10:31 -06:00
Osspial
8d6a857ba5
Merge branch 'evl2' into eventloop-2.0
2019-05-16 00:26:59 -04:00
Osspial
6ff1370035
Fix crash caused by WM_PAINT getting invoked at inopportune times. ( #866 )
2019-05-16 00:00:30 -04:00
Hal Gentz
d5391686ae
Squashed commit of the following: ( #853 )
...
commit fa95f204d3c10ceca70e794870657a0f33349761
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Sun Apr 28 00:14:01 2019 -0600
xrender
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
commit b62cee51c7b22f6f150bfe04f9b28f024e641323
Merge: 3f021ea7 a6551f46
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Thu Apr 25 18:13:43 2019 -0600
Merge branch 'macos-gentz' of github.com:ZeGentzy/winit into macos-gentz
commit 3f021ea7f7ac6bc2a697a5b6e4e6424e838a2139
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Thu Apr 25 18:04:02 2019 -0600
Get rid of warnings.
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
commit a6551f4607ea0bc26df8716dee8115371ef367db
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Thu Apr 25 07:40:56 2019 -0600
Fix example
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
commit cbfda6c57e9740b49d2b496bda43197f611cb48c
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Wed Apr 24 23:47:46 2019 -0600
Fixes
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
commit 86bc86f3d3add4a6125aa9b2eca79061c0dfcd91
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Wed Apr 24 23:39:19 2019 -0600
Backport 9a23ec3c37 (diff-1d95fe39cdbaa708c975380a16c314cb)45a4281413 (diff-1d95fe39cdbaa708c975380a16c314cb)bfbcab3a01 (diff-1d95fe39cdbaa708c975380a16c314cb)9a23ec3c37 (diff-1d95fe39cdbaa708c975380a16c314cb)45a4281413 (diff-1d95fe39cdbaa708c975380a16c314cb)bfbcab3a01 (diff-1d95fe39cdbaa708c975380a16c314cb)
2019-05-13 22:20:51 -04:00
acheronfail
062e0e52ee
Feat/fullscreen getters ( #838 )
...
* feat: [macos] add get_fullscreen and get_simple_fullscreen
* feat: [windows] add get_fullscreen
* feat: [ios] add get_fullscreen
* feat: [android] add get_fullscreen
* feat: [emscripten] add get_fullscreen
* feat: [linux] add get_fullscreen
* feedback: `get_fullscreen() -> bool` -> `get_fullscreen() -> Option<Id>`
2019-04-27 20:29:55 +02:00
Victor Berger
94f998af0a
Port X11 backend to the EVL2.0 API ( #842 )
...
* Fix compilation on Linux.
* x11: port to evl2 with stubs
* x11: Implement run_return using calloop
* wayland/x11: Make ControlFlow::Exit sticky
* x11: Send LoopDestroyed on exit
* x11: Fix RedrawRequested semandics
* wayland: Fix RedrawRequested semandics
* x11/wayland: reduce code duplication for sticky callback
2019-04-27 18:06:51 +02:00
aloucks
2253565db5
Prevent the event loop from pausing when entering modal loop (eventloop-2.0) ( #839 )
...
* Prevent the event loop from pausing after entering modal loop
After clicking the window title bar or border (for a drag or resize),
the event loop pauses until the mouse is moved. This change relays
the WM_NCLBUTTONDOWN message to the dummy window where it queues
a redraw and consumes the message. This effectively jumpstarts
the modal loop and it continues to fire draw requests.
* Handle WM_NCLBUTTONDOWN in public_window_callback instead of relaying.
Relaying the WM_NCLBUTTONDOWN message to the modal window turned out
to be unnecessary.
2019-04-14 11:48:31 -04:00
Hal Gentz
746e99c958
Add ability to get wayland display from events loop. ( #829 )
...
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
2019-04-08 08:34:49 +02:00
Osspial
47194b5f3c
Fix window icon ( #831 )
...
* Fix window icon
* Add CHANGELOG entry
2019-04-08 08:30:37 +02:00
mitchmindtree
4515b77aa5
[Rebased] [x11-backend] Retrieve DPI from Xft.dpi XResource ( #824 )
...
* [x11-backend] Retrieve DPI from Xft.dpi XResource
* Update CHANGELOG.md
* Update window.rs
* Update CHANGELOG.md
2019-04-08 08:30:09 +02:00
Christian Duerr
20b09c4514
Add additional numpad key mappings ( #805 )
...
* Add additional numpad key mappings
Since some platforms have already used the existing `Add`, `Subtract`
and `Divide` codes to map numpad keys, the X11 and Wayland platform has
been updated to achieve parity between platforms. On macOS only the
`Subtract` numpad key had to be added.
Since the numpad key is different from the normal keys, an alternative
option would be to add new `NumpadAdd`, `NumpadSubtract` and
`NumpadDivide` actions, however I think in this case it should be fine
to map them to the same virtual key code.
* Add Numpad PageUp/Down, Home and End on Wayland
2019-04-07 16:41:52 +02:00
TakWolf
9874181ccd
fix command key event left and right reverse on macOS ( #810 )
...
* fix command key event left and right reverse on macOS
https://github.com/tomaka/winit/issues/808
* update changelog
2019-04-07 16:41:52 +02:00
Tobias Kortkamp
cb93554938
Fix build on FreeBSD ( #815 )
...
* Fix build on FreeBSD
error[E0432]: unresolved import `libc::__errno_location`
--> src/platform/linux/x11/mod.rs:22:85
|
22 | use libc::{select, fd_set, FD_SET, FD_ZERO, FD_ISSET, EINTR, EINVAL, ENOMEM, EBADF, __errno_location};
| ^^^^^^^^^^^^^^^^ no `__errno_location` in the root
__errno_location is called __error on FreeBSD and __errno on Open- and NetBSD.
Signed-off-by: Tobias Kortkamp <t@tobik.me>
* Import __error / __errno on *BSD as __errno_location
Signed-off-by: Tobias Kortkamp <t@tobik.me>
* Add changelog entry
Signed-off-by: Tobias Kortkamp <t@tobik.me>
2019-04-07 16:41:52 +02:00
Osspial
17a240cd43
On Windows, fix CursorMoved(0, 0) getting sent on focus ( #819 )
...
* On Windows, fix CursorMoved(0, 0) getting sent on focus
* Add changelog entry
2019-04-07 16:41:52 +02:00
Hal Gentz
09182dc093
Use XRRGetScreenResourcesCurrent when avail. ( #801 )
...
* Use `XRRGetScreenResourcesCurrent` when avail.
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
* Changelog
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
2019-04-07 16:41:52 +02:00
Osspial
b682c3dfb5
Ignore the AltGr key when populating ModifersState ( #763 )
...
* When building ModifiersState, ignore AltGr on Windows
* Add CHANGELOG entry
* Also filter out Control when pressing AltGr
2019-04-07 16:41:52 +02:00
Riku Salminen
ab0a34012f
x11: thread safe replacement for XNextEvent ( #782 )
...
XNextEvent will block for input while holding the global Xlib mutex.
This will cause a deadlock in even the most trivial multi-threaded
application because OpenGL functions will need to hold the Xlib mutex
too.
Add EventsLoop::poll_one_event and EventsLoop::wait_for_input to provide
thread-safe functions to poll and wait events from the X11 event queue
using unix select(2) and XCheckIfEvent.
This is a somewhat ugly workaround to an ugly problem.
Fixes #779
2019-04-07 16:41:52 +02:00
Michael Palmos
f000b82d74
Fix incorrect keycodes when using a non-US keyboard layout. ( #755 )
...
* Fix incorrect keycodes when using a non-US keyboard layout.
This commit fixes the issue described in #752 , and uses the advised
method to fix it.
* Style fixes
Co-Authored-By: Toqozz <toqoz@hotmail.com>
* Refactoring of macOS `virtualkeycode` fix (#752 )
* Applies requested changes as per pull request discussion (#755 ).
2019-04-07 16:41:52 +02:00
Torkel Danielsson
dad8de82fa
Handle horizontal wheel input (Windows) ( #792 )
...
* add handler for horizontal wheel input
* add changlelog message re now handling horiz scroll on windows
2019-04-07 16:41:51 +02:00
Victor Berger
f7d7acb3c5
Cleanup some previous merge errors
2019-04-07 15:58:47 +02:00
Victor Berger
6513351e0c
Wayland's eventloop 2.0 ( #790 )
...
* match unix common API to evl 2.0
* wayland: eventloop2.0
* make EventLoopProxy require T: 'static
* Fix linux build and tests
* wayland: update sctk & small fixes
2019-02-21 10:51:43 +01:00
Osspial
9602716ed2
Event Loop 2.0 API and Windows implementation ( #638 )
...
* Rename EventsLoop and associated types to EventLoop
* Rename WindowEvent::Refresh to WindowEvent::Redraw
* Remove second thread from win32 backend
* Update run_forever to hijack thread
* Replace windows Mutex with parking_lot Mutex
* Implement new ControlFlow and associated events
* Add StartCause::Init support, timer example
* Add ability to send custom user events
* Fully invert windows control flow so win32 calls into winit's callback
* Add request_redraw
* Rename platform to platform_impl
* Rename os to platform, add Ext trait postfixes
* Add platform::desktop module with EventLoopExt::run_return
* Re-organize into module structure
* Improve documentation
* Small changes to examples
* Improve docs for run and run_return
* Change instances of "events_loop" to "event_loop"
* Rename MonitorId to MonitorHandle
* Add CHANGELOG entry
* Improve WaitUntil timer precision
* When SendEvent is called during event closure, buffer events
* Fix resize lag when waiting in some situations
* Update send test and errors that broke some examples/APIs
* Improve clarity/fix typos in docs
* Fix unreachable panic after setting ControlFlow to Poll during some RedrawRequested events.
* Fix crash when running in release mode
* Remove crossbeam dependency and make drop events work again
* Remove serde implementations from ControlFlow
* Fix 1.24.1 build
* Fix freeze when setting decorations
* Replace &EventLoop in callback with &EventLoopWindowTarget
* Document and implement Debug for EventLoopWindowTarget
* Fix some deadlocks that could occur when changing window state
* Fix thread executor not executing closure when called from non-loop thread
* Fix buffered events not getting dispatched
* Fix crash with runner refcell not getting dropped
* Address review feedback
* Fix CHANGELOG typo
* Catch panics in user callback
2019-02-05 10:30:33 -05:00
