alex/baseview
1
0
Fork 0
Code Activity
378 commits 2 branches 0 tags 751 KiB
Commit graph

378 commits

This branch
This branch
All branches
Author SHA1 Message Date
Micah Johnston 7001c2521f
Merge pull request #136 from robbert-vdh/feature/resize 
Support resizing windows after creation
 2023-01-01 17:18:12 -06:00
Robbert van der Helm 425ee7ac35 Add missing AdjustWindowRectEx() for resize 2023-01-02 00:09:25 +01:00
Robbert van der Helm be5238ec46 Replace Rcs by reference to entire WindowState 
This removes the need to pass through individual Rcs at the cost of
adding more lifetime parameters to the internals of the shared `Window`
struct and requiring an `Option` for the handler.
 2023-01-01 23:41:41 +01:00
Robbert van der Helm c10ca6b40f Clean up the Windows WindowState 
This would leak before this change.
 2023-01-01 23:05:34 +01:00
Robbert van der Helm 8e3e078220 Fix Clippy lints in macOS backend 2023-01-01 22:38:57 +01:00
Robbert van der Helm 39e97ab2be Fix Clippy lints in Windows backend 2023-01-01 22:38:49 +01:00
Robbert van der Helm 96c0401865 Replace AtomicBool with Cell<bool> 
https://github.com/RustAudio/baseview/pull/136#discussion_r1059198419
 2023-01-01 22:35:23 +01:00
Robbert van der Helm 512c3f2393 Set macOS window size using setContentSize 
I somehow completely missed this the first five times I looked through
the docs.
 2022-12-16 23:20:56 +01:00
Robbert van der Helm d7a8c52d23 Round size before resizing on macOS 
Otherwise the top row of pixels may contain flickering artifacts.
 2022-12-02 20:17:11 +01:00
Robbert van der Helm bc2b2bd458 Factor in decorations when resizing macOS window 
Apparently macOS doesn't do this for you. If you don't do this then
parts of the bottom and right of the window will be cut off.
 2022-12-02 20:17:11 +01:00
Robbert van der Helm c7b61fa39b Also resize the OpenGL view on macOS 
This fixes resizing with OpenGL applications.
 2022-12-02 20:17:11 +01:00
Robbert van der Helm e0c79c58fb Implement window resizing for macOS 
Now this works on all baseview platforms.
 2022-12-02 20:17:11 +01:00
Robbert van der Helm 80fb0a00b8 Only send resize event on macOS on actual change 
To follow the same behavior as on Linux and Windows.
 2022-12-02 20:17:11 +01:00
Robbert van der Helm 537c303ee5 Only send resize event on Windows on actual change 
To be in line with the Linux implementation.
 2022-12-02 20:17:11 +01:00
Robbert van der Helm 5a1bb0f4d8 Ensure WindowEvent::Resized fires for Linux resize 2022-12-02 20:17:11 +01:00
Robbert van der Helm 80b30ce617 Implement window resizing for Windows 2022-12-02 20:17:11 +01:00
Robbert van der Helm b8a5867436 Replace uses of Arc with Rc in Windows impl 
Everything is single threaded so there's no need to use Arcs.
 2022-11-30 20:03:12 +01:00
Robbert van der Helm c5867b6af6 Use interior mutability for Windows WindowState 
This is a prerequisite for being able to handle reentrant messages.
 2022-11-30 20:03:12 +01:00
Robbert van der Helm 3dfff613b9 Use physical sizes in X11 window resize 
And update the window info for any future events.
 2022-11-30 20:03:12 +01:00
Robbert van der Helm d61f21666c Add window resizing for X11 2022-11-30 20:03:12 +01:00
william light ee156fb884
Merge pull request #133 from robbert-vdh/feature/horizontal-scrolling 
Support horizontal scrolling on Linux and Windows
 2022-11-22 15:55:04 +01:00
Robbert van der Helm f2ca0ffa6d Support horizontal scrolling on Windows 2022-11-22 15:42:10 +01:00
Robbert van der Helm 9798d3ca86 Support horizontal scrolling on X11 
This was previously bound to the mouse forwards/back
buttons (canonically mouse 4 and 5).
 2022-11-22 15:39:49 +01:00
Robbert van der Helm 025f34b80f Map mouse forward and back correctly on X11 
Buttons 6 and 7 are for horizontal scrolling, just like buttons 4 and 5
are for vertical scrolling. I couldn't find a list of button numbers in
the X11 protocol specs, but this is what the buttons are bound to on my
Logitech G502 and
http://xahlee.info/linux/linux_x11_mouse_button_number.html also
confirms this.
 2022-11-22 15:32:43 +01:00
william light 84f10763a3
Merge pull request #132 from robbert-vdh/fix/x11-frame-pacing 
Ensure a consistent frame pacing in X11 windows
 2022-11-18 18:06:11 +01:00
Robbert van der Helm 13cc12d4e7 Ensure a consistent frame pacing in X11 windows 
The next frame's time stamp needs to be computed based on the last
frame's, not based on the current time, unless the last frame took too
long to process.
 2022-11-18 15:24:33 +01:00
William Light 1780c89baf macos/view: fix compilation 2022-11-13 02:22:53 +01:00
william light eeded04b3e
Merge pull request #110 from ingo-dsp/macos-scrollwheel 
macOS: scroll event handling
 2022-11-13 02:14:16 +01:00
william light eae4033e7d
Merge pull request #117 from robbert-vdh/feature/mouse-event-modifiers 
Add the active keyboard modifiers to the mouse events
 2022-09-22 16:36:24 +02:00
Ingo Budde 3dd255f238 Merge branch 'master' into macos-scrollwheel 2022-07-24 00:25:46 +02:00
Robbert van der Helm 5b57af2463 Add the active modifiers to the mouse event 
This would solve the most important use case for #116. Only the Linux
version has been tested, but the Windows should work perfectly fine, and
I don't know anything about macOS programming but that version also
compiles so it should be fine.
 2022-03-11 22:28:42 +01:00
Robbert van der Helm e46001a448 Remove unused mouse click event 
Since this isn't emitted anywhere, this can only lead to confusion for
library consumers. They'd need to implement their own click detection
with the button up and button down events.
 2022-03-11 22:28:42 +01:00
Micah Johnston b3712638ba
Merge pull request #115 from robbert-vdh/feature/merge-raw-gl-context 
Merge raw-gl-context into baseview to allow OpenGL contexts to be created during window creation
 2022-03-07 12:22:30 -06:00
Robbert van der Helm 85b6437de8 Swap out X11 error handling mutex for a RefCell 2022-03-07 18:53:07 +01:00
Robbert van der Helm 0aae938af0 Remove unnecessary unsafe blocks 2022-03-07 18:41:29 +01:00
Robbert van der Helm ef86e56ac7 Keep the first X11 error 2022-03-07 18:17:50 +01:00
Robbert van der Helm aa1ad823ce Use a thread local variable for the X11 error 
So in the situation that multiple X11 clients are handling errors from
different threads they don't see and interfere with each other's errors.

As mentioned in
https://github.com/glowcoil/raw-gl-context/pull/15#pullrequestreview-891405163.
 2022-03-07 18:13:47 +01:00
Robbert van der Helm ba442a4382 Fix overlapping cell borrows in Windows impl 
b4a3d2bb04 missed some immutable borrows,
but these borrows need to be local anyways because of the way the
closing is implemented.
 2022-02-10 03:14:01 +01:00
Robbert van der Helm 43860aba84 Fix a whackton of warnings and clippy lints 
The things remaining are all of the cursor things in the X11
implementation (there's _a lot_ of it, so there's probably a reason why
it's all still there but unused), and the super unsound immutable
reference to mutable reference cast in the macOS implementation that
Clippy automatically errors out on.
 2022-02-07 23:10:53 +01:00
Robbert van der Helm d83517565b Implement the OpenGL context on macOS 2022-02-07 22:43:38 +01:00
Robbert van der Helm fe107ab378 Implement the OpenGL context on Windows 2022-02-07 22:36:37 +01:00
Robbert van der Helm 2f7f177be8 Move RawWindowHandleWrapper to a shared module 
We're going to need this for the other platforms as well.
 2022-02-07 21:51:54 +01:00
Robbert van der Helm 690a94f9f1 Enable the glx feature for the x11 crate 2022-02-07 21:41:45 +01:00
Robbert van der Helm cb714401d8 Build both with and without opengl on CI 2022-02-07 20:25:01 +01:00
Robbert van der Helm 3551d5e253 Implement OpenGL contexts for X11 
This should in theory work! When requesting an OpenGL context, the
window visual is determined based on the matched framebuffer config.
 2022-02-07 20:23:13 +01:00
Robbert van der Helm b4a3d2bb04 Add stubs for creating OpenGL contexts 
There are now three todo!()s when compiling with the OpenGL flag that
need to be filled in, with the only nontrivial one being the X11
version.
 2022-02-07 19:00:48 +01:00
Robbert van der Helm 80802dfbe9 Make opengl context creation private for now 2022-02-07 18:05:32 +01:00
Robbert van der Helm 6105cae01d Mention OpenGL contexts in the readme 2022-02-07 17:59:40 +01:00
Robbert van der Helm d2e3d5d1ac Don't enable the OpenGL feature by default 2022-02-07 17:58:45 +01:00
Robbert van der Helm 0f1b8353d0 Patch up the raw-gl-context modules for a feature 
This only needed a couple changes for the raw-window-handle migration,
and for the different module paths.
 2022-02-07 17:31:19 +01:00