Osspial
76660f3621
Fix Windows backend invoking unreachable! with Exit and run_return ( #887 )
2019-05-27 13:45:26 -04:00
mtak-
3a7350cbb9
El2.0 ios ( #871 )
...
* port ios winit el2.0 implementation to the new rust-windowing repo
* unimplemented! => unreachable
trailing comma in CFRunLoopTimerCallback
* implement get_fullscreen
* add iOS specific platform documentation. Add a TODO about how to possibly extend the iOS backend to work have methods callable from more than just the main thread
* assert that window is only dropped from the main thread
* assert_main_thread called from fewer places
2019-05-25 21:10:41 -04:00
aloucks
e5aa906b01
Fix macos compile error in fullscreen example ( #885 )
2019-05-25 15:23:54 -06:00
aloucks
4b0162a013
Update parking_lot to 0.8 (for windows, too) ( #884 )
...
The previous attempt to update parking_lot missed the windows platform.
The parking_lot dependency is now no longer specified twice to help
prevent that mistake from happening again.
2019-05-25 15:23:09 -06:00
Bastien Orivel
5be88e79b0
Update parking_lot to 0.8 ( #882 )
2019-05-25 10:12:07 -06:00
Lucas Kent
93502e0cda
Fix warning ( #880 )
2019-05-24 05:10:31 -06:00
Osspial
8d6a857ba5
Merge branch 'evl2' into eventloop-2.0
2019-05-16 00:26:59 -04:00
Osspial
6ff1370035
Fix crash caused by WM_PAINT getting invoked at inopportune times. ( #866 )
2019-05-16 00:00:30 -04:00
Hal Gentz
d5391686ae
Squashed commit of the following: ( #853 )
...
commit fa95f204d3c10ceca70e794870657a0f33349761
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Sun Apr 28 00:14:01 2019 -0600
xrender
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
commit b62cee51c7b22f6f150bfe04f9b28f024e641323
Merge: 3f021ea7 a6551f46
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Thu Apr 25 18:13:43 2019 -0600
Merge branch 'macos-gentz' of github.com:ZeGentzy/winit into macos-gentz
commit 3f021ea7f7ac6bc2a697a5b6e4e6424e838a2139
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Thu Apr 25 18:04:02 2019 -0600
Get rid of warnings.
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
commit a6551f4607ea0bc26df8716dee8115371ef367db
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Thu Apr 25 07:40:56 2019 -0600
Fix example
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
commit cbfda6c57e9740b49d2b496bda43197f611cb48c
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Wed Apr 24 23:47:46 2019 -0600
Fixes
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
commit 86bc86f3d3add4a6125aa9b2eca79061c0dfcd91
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Wed Apr 24 23:39:19 2019 -0600
Backport 9a23ec3c37 (diff-1d95fe39cdbaa708c975380a16c314cb)45a4281413 (diff-1d95fe39cdbaa708c975380a16c314cb)bfbcab3a01 (diff-1d95fe39cdbaa708c975380a16c314cb)9a23ec3c37 (diff-1d95fe39cdbaa708c975380a16c314cb)45a4281413 (diff-1d95fe39cdbaa708c975380a16c314cb)bfbcab3a01 (diff-1d95fe39cdbaa708c975380a16c314cb)
2019-05-13 22:20:51 -04:00
Ryan Goldstein
70c7382a09
Fix the request_animation_frame lifetimes
2019-05-01 21:20:54 -04:00
Ryan Goldstein
9f801cf79e
Only send the request-redraw on the next animation frame
2019-04-29 15:39:43 -04:00
acheronfail
062e0e52ee
Feat/fullscreen getters ( #838 )
...
* feat: [macos] add get_fullscreen and get_simple_fullscreen
* feat: [windows] add get_fullscreen
* feat: [ios] add get_fullscreen
* feat: [android] add get_fullscreen
* feat: [emscripten] add get_fullscreen
* feat: [linux] add get_fullscreen
* feedback: `get_fullscreen() -> bool` -> `get_fullscreen() -> Option<Id>`
2019-04-27 20:29:55 +02:00
Osspial
fa99b9ff5a
Fix CI links in README.md ( #852 )
2019-04-27 18:29:02 +02:00
Felix Rabe
8f6e80917f
Popup windows are also known as modal windows ( #848 )
2019-04-27 18:28:51 +02:00
Osspial
e087ebd1c7
Makes changes to CONTRIBUTING.md's table as discussed in #830 ( #841 )
...
This includes de-listing @francesca64 from the table, as I suggested. I
realize that this is a controversial decision, and it's not a decision I
make lightly, but I believe I have justification for doing so:
I contacted @francesca64 last month asking her about her inactivity as a
maintainer on this project. She replied on March 26th as follows. For the
sake of her privacy, I've removed removed certain sections of her response,
as it contains some personal details that I'm not comfortable sharing with
the world at large without her explicit permission.
> Hello! Thanks for reaching out!❤
> In short, I've moved on. <removed> ...in November, I was hired by a
> company that recently started using Rust. I'm very happily building
> infrastructure there!
> I'm simply not interested in spending more than 8 hours a day
> programming. You couldn't even pay me to do it! My time is best spent
> going on adventures with my beloved.
> I'll still be active in the Rust ecosystem, but only insofar as the
> company I work for is. We use winit on iOS, Android, and (to a limited
> extent) macOS, so I'll work on those backends as needed.
> Thank you for taking care of winit. I hope you're taking care of
> yourself too; <removed>.
I don't begrudge her for her decision, and others shouldn't either - I
firmly believe that, as this is unpaid, volunteer work, everybody should
have the right to move on when they decide they no longer have the time
or will to contribute.
The exact impliciation of this in regards to her status as maintainer
is open to interpretation. I would argue that this means, should she in
her work stumble upon an issue in any of her listed backends, she would be
willing to submit PRs addressing those issues. However, it also means
that she is not able to put in the time to be active as a maintainer on
those platforms, or review PRs and issues for those platforms.
On March 28th I responded to her email as follows:
> Hey, thanks for responding.
> <removed, personal details>
> In the meanwhile, there are still a few loose ends from your time as
> maintainer that I'd like to get cleaned up. It's okay if you aren't
> going to be spending much time on Winit, but there's still a broad
> assumption that you're able to review PRs for them and that doesn't seem
> to be the case. Would you be able to do a couple things to ease the
> transition to whoever next takes over the macOS, X11, and Android
> backends?
> 1) Submit a PR downgrading yourself from maintainer for macOS, X11, and
> Android, so somebody else can more actively take them over.
> 2) Post your WIP macOS backend for EL2.0 as well as the issues it
> currently has, so whoever next maintains macOS can finish it.
> Going forward, I'd like to reach out to the broader Rust community and
> find more active maintainers so Winit can get to 1.0 and I can mostly
> move on from it.
I recieved no response to that email. On April 4th, I followed up on
that email:
> If you aren't able to act as a maintainer for Winit, and aren't able to
> submit a PR updating your official status as maintainer to reflect
> reality, would you mind if I submitted a PR removing you as maintainer?
> That's not something I want to do since it's a bad image for me, a bad
> image for Winit, and sets an extremely uncomfortable precedent, but I'd
> like to start more aggressive outreach to ensure each backend is less
> dependent on one specific person and I don't want to see new
> contributors pinging you for help when you're unable to provide it.
> If you don't reply by the 11th that's the path I'm going to take, but I
> consider it the nuclear option and I want to avoid invoking it if at all
> possible.
Up to this date (April 13th), I have recieved no response. Given the
amount of time I've given her to respond, as well as her lack of
response, I believe we have the justification to remove her from the
table. Should she show back up again, any clarifications on her status
would be welcome, and she is welcome to submit a PR re-listing herself
on the table with a more accurate description of her current contributor
status. However, once we begin the contributor marketing push discussed
in #830 , I don't want new contributors to attempt to ask her questions
on the macOS, X11, or Android backends when she isn't able to give a
response.
-----------------------------------------------------------------------
This PR also introduces HALL_OF_CHAMPIONS.md, which commends the efforts
of former maintainers that have contributed greatly to the Winit project.
This wasn't discussed previously, but I think it's important to recognize
the people that brought us to where we are today. It currently lists
@tomaka and @francesca64, as they are the two individuals I'm aware of
that both deserve such recognition and no longer actively contribute to
Winit, but if there's anybody I missed feel free to suggest them and a
blurb describing their work.
2019-04-27 18:28:40 +02:00
Osspial
0d3e75d6b0
Fix TODO in CONTRIBUTING.md
2019-04-27 18:28:32 +02:00
Osspial
873f7bcec7
Fix link in PULL_REQUEST_TEMPLATE.md
2019-04-27 18:28:20 +02:00
Osspial
e579a03035
Winit Features and Scope ( #695 )
...
* Add initial draft of SCOPE document
* Rephrase/rename feature tiers
* Rename to FEATURES and add a few annotations
* Fix API Reworks table
* Add more annotations
* Some phrasing
* Split compat matrix into seperate section, to be moved into wiki
* Mention compatibility in CONTRIBUTING
* Remove some discuss annotations
* Apply review changes and rename child windows feature to popup windows
* Update based on discussion
* Add issue for Android HiDPI
* Update FEATURES.md
* Update FEATURES.md
* Update PULL_REQUEST_TEMPLATE.md
* Update PULL_REQUEST_TEMPLATE.md
* Reformat FEATURES.MD
* Remove comments
* Improve formatting and add guide for extending #Features
2019-04-27 18:28:10 +02:00
Victor Berger
94f998af0a
Port X11 backend to the EVL2.0 API ( #842 )
...
* Fix compilation on Linux.
* x11: port to evl2 with stubs
* x11: Implement run_return using calloop
* wayland/x11: Make ControlFlow::Exit sticky
* x11: Send LoopDestroyed on exit
* x11: Fix RedrawRequested semandics
* wayland: Fix RedrawRequested semandics
* x11/wayland: reduce code duplication for sticky callback
2019-04-27 18:06:51 +02:00
Ryan Goldstein
fe5e300062
Clean up and document the core of stdweb event handling
2019-04-25 00:02:13 -04:00
aloucks
2253565db5
Prevent the event loop from pausing when entering modal loop (eventloop-2.0) ( #839 )
...
* Prevent the event loop from pausing after entering modal loop
After clicking the window title bar or border (for a drag or resize),
the event loop pauses until the mouse is moved. This change relays
the WM_NCLBUTTONDOWN message to the dummy window where it queues
a redraw and consumes the message. This effectively jumpstarts
the modal loop and it continues to fire draw requests.
* Handle WM_NCLBUTTONDOWN in public_window_callback instead of relaying.
Relaying the WM_NCLBUTTONDOWN message to the modal window turned out
to be unnecessary.
2019-04-14 11:48:31 -04:00
Osspial
2ead1c1c59
Update for 0.19.1 ( #823 )
2019-04-08 08:35:36 +02:00
Hal Gentz
746e99c958
Add ability to get wayland display from events loop. ( #829 )
...
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
2019-04-08 08:34:49 +02:00
Osspial
47194b5f3c
Fix window icon ( #831 )
...
* Fix window icon
* Add CHANGELOG entry
2019-04-08 08:30:37 +02:00
mitchmindtree
4515b77aa5
[Rebased] [x11-backend] Retrieve DPI from Xft.dpi XResource ( #824 )
...
* [x11-backend] Retrieve DPI from Xft.dpi XResource
* Update CHANGELOG.md
* Update window.rs
* Update CHANGELOG.md
2019-04-08 08:30:09 +02:00
Christian Duerr
20b09c4514
Add additional numpad key mappings ( #805 )
...
* Add additional numpad key mappings
Since some platforms have already used the existing `Add`, `Subtract`
and `Divide` codes to map numpad keys, the X11 and Wayland platform has
been updated to achieve parity between platforms. On macOS only the
`Subtract` numpad key had to be added.
Since the numpad key is different from the normal keys, an alternative
option would be to add new `NumpadAdd`, `NumpadSubtract` and
`NumpadDivide` actions, however I think in this case it should be fine
to map them to the same virtual key code.
* Add Numpad PageUp/Down, Home and End on Wayland
2019-04-07 16:41:52 +02:00
TakWolf
9874181ccd
fix command key event left and right reverse on macOS ( #810 )
...
* fix command key event left and right reverse on macOS
https://github.com/tomaka/winit/issues/808
* update changelog
2019-04-07 16:41:52 +02:00
Tobias Kortkamp
cb93554938
Fix build on FreeBSD ( #815 )
...
* Fix build on FreeBSD
error[E0432]: unresolved import `libc::__errno_location`
--> src/platform/linux/x11/mod.rs:22:85
|
22 | use libc::{select, fd_set, FD_SET, FD_ZERO, FD_ISSET, EINTR, EINVAL, ENOMEM, EBADF, __errno_location};
| ^^^^^^^^^^^^^^^^ no `__errno_location` in the root
__errno_location is called __error on FreeBSD and __errno on Open- and NetBSD.
Signed-off-by: Tobias Kortkamp <t@tobik.me>
* Import __error / __errno on *BSD as __errno_location
Signed-off-by: Tobias Kortkamp <t@tobik.me>
* Add changelog entry
Signed-off-by: Tobias Kortkamp <t@tobik.me>
2019-04-07 16:41:52 +02:00
Hal Gentz
6b7bd32c8e
Add contact info. ( #818 )
...
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
2019-04-07 16:41:52 +02:00
Osspial
17a240cd43
On Windows, fix CursorMoved(0, 0) getting sent on focus ( #819 )
...
* On Windows, fix CursorMoved(0, 0) getting sent on focus
* Add changelog entry
2019-04-07 16:41:52 +02:00
Osspial
fc481b6d6d
Update winit to 0.19.0 ( #798 )
...
* Update winit to 0.19.0
* Update date for 0.19
2019-04-07 16:41:52 +02:00
Hal Gentz
09182dc093
Use XRRGetScreenResourcesCurrent when avail. ( #801 )
...
* Use `XRRGetScreenResourcesCurrent` when avail.
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
* Changelog
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
2019-04-07 16:41:52 +02:00
Osspial
b682c3dfb5
Ignore the AltGr key when populating ModifersState ( #763 )
...
* When building ModifiersState, ignore AltGr on Windows
* Add CHANGELOG entry
* Also filter out Control when pressing AltGr
2019-04-07 16:41:52 +02:00
Riku Salminen
ab0a34012f
x11: thread safe replacement for XNextEvent ( #782 )
...
XNextEvent will block for input while holding the global Xlib mutex.
This will cause a deadlock in even the most trivial multi-threaded
application because OpenGL functions will need to hold the Xlib mutex
too.
Add EventsLoop::poll_one_event and EventsLoop::wait_for_input to provide
thread-safe functions to poll and wait events from the X11 event queue
using unix select(2) and XCheckIfEvent.
This is a somewhat ugly workaround to an ugly problem.
Fixes #779
2019-04-07 16:41:52 +02:00
Michael Palmos
f000b82d74
Fix incorrect keycodes when using a non-US keyboard layout. ( #755 )
...
* Fix incorrect keycodes when using a non-US keyboard layout.
This commit fixes the issue described in #752 , and uses the advised
method to fix it.
* Style fixes
Co-Authored-By: Toqozz <toqoz@hotmail.com>
* Refactoring of macOS `virtualkeycode` fix (#752 )
* Applies requested changes as per pull request discussion (#755 ).
2019-04-07 16:41:52 +02:00
Torkel Danielsson
dad8de82fa
Handle horizontal wheel input (Windows) ( #792 )
...
* add handler for horizontal wheel input
* add changlelog message re now handling horiz scroll on windows
2019-04-07 16:41:51 +02:00
trimental
3fea477bfd
On wayland, fix with_title() not setting the windows title ( #770 )
2019-04-07 16:39:55 +02:00
Victor Berger
f7d7acb3c5
Cleanup some previous merge errors
2019-04-07 15:58:47 +02:00
Ryan Goldstein
9e25561edf
Fix compile failures and add canvas positioning
2019-04-02 22:31:30 -04:00
Ryan Goldstein
7c6bdcc459
Handle ControlFlow::Exit and dealing with events-in-events
2019-03-22 22:15:49 -04:00
Ryan Goldstein
b09629f1d4
Handle ControlFlow::Exit
2019-03-18 22:13:30 -04:00
Ryan Goldstein
85446d81f3
Fix warnings
2019-03-16 18:51:11 -04:00
Ryan Goldstein
96786bbb87
Implement focus event
2019-03-16 18:44:13 -04:00
Ryan Goldstein
a5166baba2
Implement request_redraw
2019-03-16 18:40:35 -04:00
Ryan Goldstein
d1deba8620
Rename modules
2019-03-11 22:22:21 -04:00
Ryan Goldstein
aaee72422a
Rearchitect to allow API compliance
2019-03-11 22:18:58 -04:00
Ryan Goldstein
3dd0e31cc4
Merge eventloop-2.0 into stdweb-eventloop-2
2019-03-11 15:52:04 -04:00
Ryan Goldstein
283a8dec37
Refactor out the stdweb functionality into different modules
2019-03-09 22:23:39 -05:00
Ryan Goldstein
37d354cf7f
Get to a state where a canvas is spawned
2019-03-09 21:54:29 -05:00
Ryan Goldstein
f698d451df
Add key and mouse event support that typechecks
2019-03-02 12:31:16 -05:00
