Ben Merritt
91a511ba8c
Replace JS snippet with throw_str
2019-06-17 22:54:07 -07:00
Ben Merritt
94f6294c0a
Prevent callbacks from being destroyed too early
2019-06-17 22:54:07 -07:00
Ben Merritt
77cd3adb01
TEMPORARY: add testing example
2019-06-17 22:54:07 -07:00
Ben Merritt
7dabad4d71
Fix throwToEscapeEventLoop function
2019-06-17 22:51:23 -07:00
Ben Merritt
54b4074369
Port remaining modules to web_sys
2019-06-17 22:51:23 -07:00
Ben Merritt
e4d8e22846
Start implementing web-sys backend
2019-06-17 22:51:23 -07:00
Felix Rabe
403dcc02f4
CONTRIBUTING.md: Linkify project members ( #933 )
2019-06-17 16:52:30 -06:00
Felix Rabe
64be6e5c5e
Typo ( #932 )
2019-06-17 16:22:01 -06:00
Felix Rabe
c661006683
Use dbg!() macro in monitor list example ( #931 )
2019-06-17 16:13:35 -06:00
CrLF0710
f879bca21c
Migrate to 2018 edition. ( #924 )
...
* Migrate to 2018 edition.
* Use impl Iterator at one site.
* Fix more rust 2018 idioms.
2019-06-17 14:27:00 -04:00
Ryan Goldstein
182beb4f8b
Indicate that I will be maintaing the stdweb backend
2019-06-16 21:34:54 -07:00
Ryan Goldstein
2690306f4a
Implement Poll and WaitUntil in the stdweb backend
2019-06-16 21:30:05 -07:00
Ryan Goldstein
b59e3c670b
WIP
2019-06-14 21:15:43 -07:00
Osspial
2e0bbc091f
Set CHANGELOG.md merge style to union ( #919 )
2019-06-13 16:11:44 -04:00
Aleksi Juvani
91f05e940f
Fix initial dimensions of a fullscreen window on Windows ( #909 )
2019-06-13 15:17:56 -04:00
Aleksi Juvani
db794b976c
Disable caching on Travis ( #918 )
2019-06-13 14:24:44 -04:00
Victor Berger
9a11f90a02
x11/wayland: Don't reset control flow between loop ticks ( #916 )
2019-06-13 12:52:10 -04:00
Osspial
412516159f
Document the caveats of run_return ( #914 )
2019-06-13 12:51:44 -04:00
Victor Berger
65587ef43a
wayland: use an invisible surface as shell surface ( #835 )
...
This decorelates the window management from the actual user content,
meaning:
- the created window no longer needs the user to draw something to
start existing
- it reduces our need to do roundtrips during initialization to
avoid protocol errors
2019-06-13 12:50:02 -04:00
Osspial
cf713bef31
Remove CircleCI ( #915 )
...
None of the platforms that use it are supported right now, so it seems
silly to fail builds for other platforms when these ones can't possibly
succeed.
This should be reverted in stages as the platforms regain support.
2019-06-13 00:34:21 -06:00
Osspial
ea5c21950c
Change Monitor dimensions functions to size functions ( #911 )
2019-06-13 00:33:44 -06:00
Aleksi Juvani
47b5dfa034
Support listing available video modes for a monitor ( #896 )
...
* Support listing available video modes for a monitor
* Use derivative for Windows `MonitorHandle`
* Update FEATURES.md
* Fix multiline if statement
* Add documentation for `VideoMode` type
2019-06-12 14:07:25 -04:00
Osspial
2b89ddec15
Fix WindowBuilder function names that missed first pass ( #910 )
2019-06-12 13:34:09 -04:00
Nikolai Vazquez
f256ff7d58
Make ns identifiers use snake_case on macOS ( #904 )
...
This makes the macOS API style consistent with that of iOS.
2019-06-10 19:09:38 -04:00
Christian Duerr
07356b9634
Update cursor visibility docs ( #893 )
...
The cursor visibility docs were still outdated from the rename and
talking about setting the invisibility, rather than visibility.
The platform-specific docs are unchanged since those should be fine and
the rest has been adapted using similar docs.
2019-06-01 18:06:41 -06:00
Ryan Goldstein
f2b6ef2edd
Merge master into stdweb-eventloop-2
...
Update the internal APIs to match the new API changes
2019-06-01 13:21:50 -07:00
Ryan Goldstein
1409f83fb9
Add support for mouse wheel
2019-05-31 21:50:34 -07:00
Ryan Goldstein
37dadab745
Add access to the canvas in the Window
2019-05-31 21:50:25 -07:00
Osspial
0eefa3ba42
Fix compiler warning of potential undefined behavior ( #892 )
2019-05-30 20:42:53 -04:00
aloucks
08f8f89702
Fix control flow issues with Window::request_redraw (eventloop-2.0) ( #890 )
...
* Fix request_redraw with Poll and WaitUntil(time_in_the_past) on Windows
`Window::request_redraw` now fires a `RedrawRequested` event when
called from an `Event::EventsCleared` callback while the control
flow is set to `Poll`. A control flow of `WaitUntil(resume_time)`,
will now also fire the `RedrawRequested` event when `resume_time`
is in the past.
* Prevent panic on x11 when WaitUntil(resume_time) is in the past
* Prevent panic on wayland when WaitUntil(resume_time) is in the past
2019-05-29 22:33:52 -06:00
Osspial
0df436901a
Refine function names and type signatures ( #886 )
...
* First name consistency pass. More to come!
* Remove multitouch variable (hopefully this compiles!)
* Remove CreationError::NotSupported
* Add new error handling types
* Remove `get_` prefix from getters.
This is as per the Rust naming conventions recommended in
https://rust-lang-nursery.github.io/api-guidelines/naming.html#getter-names-follow-rust-convention-c-getter
* Make changes to Window position and size function signatures
* Remove CreationError in favor of OsError
* Begin updating iOS backend
* Change MonitorHandle::outer_position to just position
* Fix build on Windows and Linux
* Add Display and Error implementations to Error types
* Attempt to fix iOS build.
I can't actually check that this works since I can't cross-compile to
iOS on a Windows machine (thanks apple :/) but this should be one of
several commits to get it working.
* Attempt to fix iOS errors, and muck up Travis to make debugging easier
* More iOS fixins
* Add Debug and Display impls to OsError
* Fix Display impl
* Fix unused code warnings and travis
* Rename set_ime_spot to set_ime_position
* Add CHANGELOG entry
* Rename set_cursor to set_cursor_icon and MouseCursor to CursorIcon
* Organize Window functions into multiple, categorized impls
* Improve clarity of function ordering and docs in EventLoop
2019-05-29 21:29:54 -04:00
Osspial
ae63fbdbbb
Merge branch 'eventloop-2.0' of https://github.com/tomaka/winit into eventloop-2.0
2019-05-29 21:28:39 -04:00
Osspial
4f29618c73
I forgot to remove the backtrace dependency in the EL2 rework
2019-05-29 21:22:35 -04:00
Osspial
76660f3621
Fix Windows backend invoking unreachable! with Exit and run_return ( #887 )
2019-05-27 13:45:26 -04:00
mtak-
3a7350cbb9
El2.0 ios ( #871 )
...
* port ios winit el2.0 implementation to the new rust-windowing repo
* unimplemented! => unreachable
trailing comma in CFRunLoopTimerCallback
* implement get_fullscreen
* add iOS specific platform documentation. Add a TODO about how to possibly extend the iOS backend to work have methods callable from more than just the main thread
* assert that window is only dropped from the main thread
* assert_main_thread called from fewer places
2019-05-25 21:10:41 -04:00
aloucks
e5aa906b01
Fix macos compile error in fullscreen example ( #885 )
2019-05-25 15:23:54 -06:00
aloucks
4b0162a013
Update parking_lot to 0.8 (for windows, too) ( #884 )
...
The previous attempt to update parking_lot missed the windows platform.
The parking_lot dependency is now no longer specified twice to help
prevent that mistake from happening again.
2019-05-25 15:23:09 -06:00
Bastien Orivel
5be88e79b0
Update parking_lot to 0.8 ( #882 )
2019-05-25 10:12:07 -06:00
Lucas Kent
93502e0cda
Fix warning ( #880 )
2019-05-24 05:10:31 -06:00
Osspial
8d6a857ba5
Merge branch 'evl2' into eventloop-2.0
2019-05-16 00:26:59 -04:00
Osspial
6ff1370035
Fix crash caused by WM_PAINT getting invoked at inopportune times. ( #866 )
2019-05-16 00:00:30 -04:00
Hal Gentz
d5391686ae
Squashed commit of the following: ( #853 )
...
commit fa95f204d3c10ceca70e794870657a0f33349761
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Sun Apr 28 00:14:01 2019 -0600
xrender
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
commit b62cee51c7b22f6f150bfe04f9b28f024e641323
Merge: 3f021ea7 a6551f46
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Thu Apr 25 18:13:43 2019 -0600
Merge branch 'macos-gentz' of github.com:ZeGentzy/winit into macos-gentz
commit 3f021ea7f7ac6bc2a697a5b6e4e6424e838a2139
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Thu Apr 25 18:04:02 2019 -0600
Get rid of warnings.
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
commit a6551f4607ea0bc26df8716dee8115371ef367db
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Thu Apr 25 07:40:56 2019 -0600
Fix example
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
commit cbfda6c57e9740b49d2b496bda43197f611cb48c
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Wed Apr 24 23:47:46 2019 -0600
Fixes
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
commit 86bc86f3d3add4a6125aa9b2eca79061c0dfcd91
Author: Hal Gentz <zegentzy@protonmail.com>
Date: Wed Apr 24 23:39:19 2019 -0600
Backport 9a23ec3c37 (diff-1d95fe39cdbaa708c975380a16c314cb)45a4281413 (diff-1d95fe39cdbaa708c975380a16c314cb)bfbcab3a01 (diff-1d95fe39cdbaa708c975380a16c314cb)9a23ec3c37 (diff-1d95fe39cdbaa708c975380a16c314cb)45a4281413 (diff-1d95fe39cdbaa708c975380a16c314cb)bfbcab3a01 (diff-1d95fe39cdbaa708c975380a16c314cb)
2019-05-13 22:20:51 -04:00
Ryan Goldstein
70c7382a09
Fix the request_animation_frame lifetimes
2019-05-01 21:20:54 -04:00
Ryan Goldstein
9f801cf79e
Only send the request-redraw on the next animation frame
2019-04-29 15:39:43 -04:00
acheronfail
062e0e52ee
Feat/fullscreen getters ( #838 )
...
* feat: [macos] add get_fullscreen and get_simple_fullscreen
* feat: [windows] add get_fullscreen
* feat: [ios] add get_fullscreen
* feat: [android] add get_fullscreen
* feat: [emscripten] add get_fullscreen
* feat: [linux] add get_fullscreen
* feedback: `get_fullscreen() -> bool` -> `get_fullscreen() -> Option<Id>`
2019-04-27 20:29:55 +02:00
Osspial
fa99b9ff5a
Fix CI links in README.md ( #852 )
2019-04-27 18:29:02 +02:00
Felix Rabe
8f6e80917f
Popup windows are also known as modal windows ( #848 )
2019-04-27 18:28:51 +02:00
Osspial
e087ebd1c7
Makes changes to CONTRIBUTING.md's table as discussed in #830 ( #841 )
...
This includes de-listing @francesca64 from the table, as I suggested. I
realize that this is a controversial decision, and it's not a decision I
make lightly, but I believe I have justification for doing so:
I contacted @francesca64 last month asking her about her inactivity as a
maintainer on this project. She replied on March 26th as follows. For the
sake of her privacy, I've removed removed certain sections of her response,
as it contains some personal details that I'm not comfortable sharing with
the world at large without her explicit permission.
> Hello! Thanks for reaching out!❤
> In short, I've moved on. <removed> ...in November, I was hired by a
> company that recently started using Rust. I'm very happily building
> infrastructure there!
> I'm simply not interested in spending more than 8 hours a day
> programming. You couldn't even pay me to do it! My time is best spent
> going on adventures with my beloved.
> I'll still be active in the Rust ecosystem, but only insofar as the
> company I work for is. We use winit on iOS, Android, and (to a limited
> extent) macOS, so I'll work on those backends as needed.
> Thank you for taking care of winit. I hope you're taking care of
> yourself too; <removed>.
I don't begrudge her for her decision, and others shouldn't either - I
firmly believe that, as this is unpaid, volunteer work, everybody should
have the right to move on when they decide they no longer have the time
or will to contribute.
The exact impliciation of this in regards to her status as maintainer
is open to interpretation. I would argue that this means, should she in
her work stumble upon an issue in any of her listed backends, she would be
willing to submit PRs addressing those issues. However, it also means
that she is not able to put in the time to be active as a maintainer on
those platforms, or review PRs and issues for those platforms.
On March 28th I responded to her email as follows:
> Hey, thanks for responding.
> <removed, personal details>
> In the meanwhile, there are still a few loose ends from your time as
> maintainer that I'd like to get cleaned up. It's okay if you aren't
> going to be spending much time on Winit, but there's still a broad
> assumption that you're able to review PRs for them and that doesn't seem
> to be the case. Would you be able to do a couple things to ease the
> transition to whoever next takes over the macOS, X11, and Android
> backends?
> 1) Submit a PR downgrading yourself from maintainer for macOS, X11, and
> Android, so somebody else can more actively take them over.
> 2) Post your WIP macOS backend for EL2.0 as well as the issues it
> currently has, so whoever next maintains macOS can finish it.
> Going forward, I'd like to reach out to the broader Rust community and
> find more active maintainers so Winit can get to 1.0 and I can mostly
> move on from it.
I recieved no response to that email. On April 4th, I followed up on
that email:
> If you aren't able to act as a maintainer for Winit, and aren't able to
> submit a PR updating your official status as maintainer to reflect
> reality, would you mind if I submitted a PR removing you as maintainer?
> That's not something I want to do since it's a bad image for me, a bad
> image for Winit, and sets an extremely uncomfortable precedent, but I'd
> like to start more aggressive outreach to ensure each backend is less
> dependent on one specific person and I don't want to see new
> contributors pinging you for help when you're unable to provide it.
> If you don't reply by the 11th that's the path I'm going to take, but I
> consider it the nuclear option and I want to avoid invoking it if at all
> possible.
Up to this date (April 13th), I have recieved no response. Given the
amount of time I've given her to respond, as well as her lack of
response, I believe we have the justification to remove her from the
table. Should she show back up again, any clarifications on her status
would be welcome, and she is welcome to submit a PR re-listing herself
on the table with a more accurate description of her current contributor
status. However, once we begin the contributor marketing push discussed
in #830 , I don't want new contributors to attempt to ask her questions
on the macOS, X11, or Android backends when she isn't able to give a
response.
-----------------------------------------------------------------------
This PR also introduces HALL_OF_CHAMPIONS.md, which commends the efforts
of former maintainers that have contributed greatly to the Winit project.
This wasn't discussed previously, but I think it's important to recognize
the people that brought us to where we are today. It currently lists
@tomaka and @francesca64, as they are the two individuals I'm aware of
that both deserve such recognition and no longer actively contribute to
Winit, but if there's anybody I missed feel free to suggest them and a
blurb describing their work.
2019-04-27 18:28:40 +02:00
Osspial
0d3e75d6b0
Fix TODO in CONTRIBUTING.md
2019-04-27 18:28:32 +02:00
Osspial
873f7bcec7
Fix link in PULL_REQUEST_TEMPLATE.md
2019-04-27 18:28:20 +02:00
