Commit graph

489 commits

Author SHA1 Message Date
Jan Niehusmann
b80833ad62 Update CHANGELOG.md 2022-12-09 21:11:23 +00:00
Murat Ursavaş
dfc790b207
Fixed: First frame is getting lost on a USB-CDC device. (#510)
**Issue**

While using `usb_device` and `usbd_serial` crates with `rp2040_hal`, the first frame from the host device is always getting lost. Consecutive frames work just fine.

**Root Cause**
The `LENGTH_0` region of the `EP_BUFFER_CONTROL` register is always reset (0) while waiting for the first frame. After the first frame failure, the poll operation implicitly sets it  to the necessary value (`max_packet_size`) and this clears the problem for the rest of the app execution life time.

The main problem is while resetting and readjustment of the bits needs a step by step operation to avoid potential issues. While doing that and setting `AVAILABLE` bit, the wrong method had been chosen and was invalidating previous changes. Hence the `LENGTH_0` param is reset, too.

**Proposed Solution**
Instead of direct register `write` operation I've used `modify` to keep current bits in the register.

Co-authored-by: Murat Ursavas <mursavas@nebra.com>
2022-12-04 10:19:06 +11:00
Wilfried Chauveau
119534d2da
usb: Read ints rather than sie_status in poll (#493)
If the latency is too high, there is a risk that the status reverts to a
previous state while keeping the interrupt flag up.
This fixes that by relying on ints instead of sie_status to process the
events.
2022-11-28 18:08:23 +00:00
Jan Niehusmann
0055dbaf87
Fix some clippy warnings flagged by current beta (#505)
* Fix some clippy warnings flagged by current beta

(One warning was just silenced because I consider the current code more readable)

* cargo fmt
2022-11-25 17:08:20 +00:00
Jan Niehusmann
e3a6612366 Remove support for deprecated version 0.2 of critical-section 2022-11-22 19:38:59 +00:00
Jan Niehusmann
4b2b33b950
Merge pull request #494 from jannic/pio-change-clkdiv
Allow setting clock divisors on running state machines
2022-11-17 09:35:39 +01:00
Jan Niehusmann
f00ea66ccd
Merge pull request #497 from jannic/dead-code-RpSpinlockCs
Avoid dead_code warning if critical-section-impl is not enabled
2022-11-13 11:12:25 +01:00
Jan Niehusmann
40f3f42c70
Merge pull request #496 from icedrocket/main
build: add docs.rs metadata
2022-11-12 18:09:23 +01:00
Jan Niehusmann
c1988432c8 Avoid dead_code warning if critical-section-impl is not enabled
Also make Spinlock31 public if it's not used by the critical section impl
2022-11-12 14:17:45 +00:00
icedrocket
1b72a48870 build: add docs.rs metadata 2022-11-12 22:26:32 +09:00
Jan Niehusmann
caea9ecfd7 Update rp2040-hal version in README.md 2022-11-11 08:34:04 +00:00
Jan Niehusmann
2f077a434b Update doc comment of set_clock_divisor, clock_divisor_fixed_point 2022-11-10 21:17:48 +00:00
Jan Niehusmann
81da6f12fe Allow setting clock divisors on running state machines
The documentation of CLKDIV_RESTART contains the following sentence:

"Note also that CLKDIV_RESTART can be written to whilst the state
machine is running, and this is useful to resynchronise clock dividers
after the divisors (SMx_CLKDIV) have been changed on-the-fly."

This implies that it's allowed to change the value of CLKDIV on a
running state machine.
2022-11-09 15:34:44 +00:00
Jan Niehusmann
0ecf27450a
Merge pull request #484 from davidcole1340/program-wrap
Add ability to modify installed program wrap bounds
2022-11-07 20:34:35 +01:00
Jan Niehusmann
f0d7cd998f
Merge pull request #473 from jannic/update-changelog
Update CHANGELOG
2022-11-02 00:13:00 +01:00
Jan Niehusmann
5ae1f90939
Merge pull request #488 from ptpaterson/eh1_0_alpha-spi
implement embedded-hal aplha SPI traits
2022-10-30 13:47:11 +01:00
9names
9bc48de974
Merge pull request #486 from 9names/error_add_debug_traits
Add derive(Debug) and derive(defmt::Format) to error types.

pll and xosc Error types didn't implement Debug, which made them annoying to work with.
And only a few of our Error types implemented derive(defmt::Format).
I added both to all the errors I could find to make things a little more consistent.
2022-10-29 08:31:02 +11:00
Jan Niehusmann
f2d9fff0e2
Specify required feature critical-section-impl for some examples (#487) 2022-10-28 22:15:32 +01:00
Paul Paterson
98daa7a25d implement embedded-hal aplha SPI traits 2022-10-28 13:21:55 -04:00
Jan Niehusmann
e60a979eda
Merge pull request #483 from zachs18/patch-1
Remove unnecessary `mut` from `static mut LOCK_OWNER: AtomicU8` in critical section impl.
2022-10-28 18:27:24 +02:00
Jan Niehusmann
4ca2dcfd20
Update rp2040-hal/CHANGELOG.md
Co-authored-by: 9names <60134748+9names@users.noreply.github.com>
2022-10-28 18:26:13 +02:00
9names
219d393085 Add derive(Debug) and derive(defmt::Format) to error types 2022-10-27 19:17:03 +11:00
David Cole
3c06a3359e do not include offset when checking wrap bounds 2022-10-27 12:57:35 +13:00
David Cole
1ba07b09e7 Add ability to modify installed program wrap bounds
The wrap source and target cannot change after installing the program
into the PIO at present, even though this is possible with the C/C++
HAL. This is useful when using the same program across multiple state
machines that have different wrap sources and targets.
2022-10-26 21:03:58 +13:00
Jan Niehusmann
8e79f438ba
Merge pull request #467 from jannic/fix-466
Use InstalledProgram::share() in examples/pio_synchronized.rs
2022-10-25 23:34:36 +02:00
zachs18
2b8dda74aa
Remove unnecessary mut from static mut LOCK_OWNER: AtomicU8 in critical section impl.
`LOCK_OWNER` is only accessed using the atomic APIs, which take `&self`, so it does not need to be `static mut`, `static` is fine.

(I haven't seen any miscompilations of this, but I'm unsure if Rust is allowed to assume `static mut`s are not aliased and apply optimizations based on that. If so, this would prevent that.)
2022-10-25 13:16:03 -05:00
Jan Niehusmann
018965d015 Update dependency on rp2040-pac to 0.4.0 2022-10-18 20:11:24 +00:00
Jan Niehusmann
95598ad199 Update CHANGELOG 2022-10-18 20:06:19 +00:00
Derek Hageman
04e245813a Add CHANGELOG entry for UART error field
Add a changelog entry documenting the change to the UART error field
name.
2022-10-16 20:22:17 -06:00
Derek Hageman
c461d21136 Fix UART read error discard data
Limit the discarded data reference to the data that has actually been
read so far, instead of the whole input buffer.  Also fix a spelling
error in the field name.
2022-10-16 10:59:26 -06:00
Jan Niehusmann
d8a0c64618 Make UartConfig::new(...) const 2022-10-15 17:34:13 +00:00
Jan Niehusmann
e9428c3f57 Add CHANGELOG entries 2022-10-15 17:14:43 +00:00
Jan Niehusmann
fb7fba03ad Add deprecation attribute to common_configs 2022-10-15 17:14:43 +00:00
Jan Niehusmann
b81ad6f599 Use UartConfig::new constructor instead of common_configs in examples 2022-10-15 17:14:43 +00:00
Jan Niehusmann
0a86dad34c Implement UartConfig::new constructor method 2022-10-15 17:02:30 +00:00
Jan Niehusmann
84b92edd30 Check watchdog load value max value before multiplying by 2, to avoid integer overflow 2022-10-12 22:39:57 +00:00
Jan Niehusmann
e9923cbcd2 Use InstalledProgram::share() in examples/pio_synchronized.rs 2022-10-11 21:04:04 +00:00
Derek Hageman
39190c357f
Fix watchdog counter load (#464)
Fix the watchdog load to reflect the 1us tick rate.  This was changed
in #361, which presumably used the field name (delay_ms) and assumed
it was in milliseconds.  So this also fixes the name to reflect that
it's microseconds.
2022-10-10 12:15:24 +01:00
Wilfried Chauveau
eac51cdd16
remove unused future dependency (#463) 2022-10-06 21:39:48 +01:00
Wilfried Chauveau
305dfc9d1f
Add rtic-monotonic support for timer & alarms (feature gated) (#459)
* Add rtic-monotonic support for timer & alarms
* Force Alarm interrupt if timer is set too soon
* timer: Remove non_exhaustive attribute from ScheduleAlarmError
* timer: TooSoon is no longer emitted so it can be removed
2022-10-06 18:31:31 +01:00
9names
fc110f07c3 Add comments for HAL features 2022-10-03 11:43:09 +11:00
Jan Niehusmann
d5bfb0ca8d Fix typo in changelog 2022-09-30 16:53:37 +00:00
Jan Niehusmann
819f051cc2 Update changelog 2022-09-28 21:59:09 +00:00
Jan Niehusmann
fcd6f7c19d Remove unnecessary custom Infallible types 2022-09-28 21:59:09 +00:00
Jan Niehusmann
e4deaabb51 Upgraded embedded-hal alpha dependency to 1.0.0-alpha.9
For now, disabled non-blocking implementations.
2022-09-28 21:59:09 +00:00
Jan Niehusmann
8d9b4538c9
Merge pull request #453 from jannic/update-jmp-offset
simplify jump offset calculation when loading PIO programs
2022-09-27 22:25:22 +02:00
Olivier
69c047136c added SPI is_busy function 2022-09-19 15:27:46 +02:00
Jan Niehusmann
6a5747b213 Use u8 instead of usize for pio address calculation 2022-09-18 10:48:09 +00:00
Jan Niehusmann
7cca9a71d7 simplify jump offset calculation when loading PIO programs 2022-09-17 17:22:34 +00:00
Jan Niehusmann
fa83510277 Provide rp2040_hal::gpio::pin::Pin::into_push_pull_output_in_state 2022-09-17 13:31:11 +00:00